0036701: [SERQA 3212] EnableButtonsCallback is not done in cancellation of BeforeCustomerAddrSave hook

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036701

Retail Modules

Web POS

public

2017-08-23 10:22

2017-09-15 11:56

Reporter

jonibc

Assigned To

jorge-garcia

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR17Q4

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0036701: [SERQA 3212] EnableButtonsCallback is not done in cancellation of BeforeCustomerAddrSave hook

Description

If cancellation argument is true, enableButtonsCallback is not done.

The buttons get blocked and it is not possible to save any new address until a refresh is done.

Steps To Reproduce

Implement a hook where we always set args.cancellation = true.

Check that buttons for addresses are blocked until a refresh is done.

Proposed Solution

Do call to enableButtonsCallback before return true in cancellation of BeforeCustomerAddrSave hook. Check the following extract of code.

                OB.UTIL.HookManager.executeHooks('OBPOS_BeforeCustomerAddrSave', {
                    customerAddr: this.model.get('customerAddr'),
                    isNew: true,
                    windowComponent: me
                }, function(args) {
                    if (args && args.cancellation && args.cancellation === true) {
                        // Add enableButtonsCallback
                        enableButtonsCallback();
                        return true;
                    }

Additional Information