Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0036457
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2017-07-11 13:032017-07-12 12:01
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q4
StatusclosedFix in branchFixed in SCM revision5a4d53a0947f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036457: inconsistent grid state if cancelling changes before receiving FIC response

DescriptionWhen editing in grid mode, it is possible to reach to an inconsistent state if cancel changes button is clicked while a FIC request has done but it has not been yet processed. This is easier to reproduce in case of long FIC requests due either slow network or performance issues in callouts implementation.
Steps To Reproduce* case 1
  1.1. Add artificial delay in SL_Order_Product callout code: Thread.sleep(5_000L);
  1.2. Create a Sales Quotation header
  1.2. Insert Row in grid mode
  1.3. Select a product
  1.4. Before callout response is received click on cancel changes button
    -> When callout response is received and processed a new incorrect line is created with only few fields populated (see attached image 192)

* case 2
  2.1. Add artificial delay in SL_Order_Product callout code: Thread.sleep(5_000L);
  2.2. Insert two lines both with Agua sin Gas as product (check price is 1.53 for them)
  2.3. Select 1st line
  2.4. Click on new in grid -> check new row is created between 1st and 2nd
  2.5. Select Cerveza as product
  2.6. Before callout response is received, cancel changes and edit 2nd row
     -> Check price is changed from 1.53 to 2.04: when callout response is received and processed values from cancelled edition are wrongly applied to current record.
TagsNo tags attached.
Attached Filespng file icon Selection_192.png [^] (64,610 bytes) 2017-07-11 13:04


png file icon Selection_193.png [^] (21,425 bytes) 2017-07-11 13:15

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0036454 closedalostale editing in grid record can be saved before callouts are applied 
depends on backport 00364693.0PR17Q3 closedalostale inconsistent grid state if cancelling changes before receiving FIC response 
related to defect 0036459 closedcaristu error thrown when refreshing after cancelling row creation before FIC response is processed 

-  Notes
(0098032)
hgbot (developer)
2017-07-12 08:20

Repository: erp/devel/pi
Changeset: 5a4d53a0947fb4393d02af70ade0b4e911e88659
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 11 13:29:02 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5a4d53a0947fb4393d02af70ade0b4e911e88659 [^]

fixed 36457: inconsistent grid state if cancelling changes before FIC response

  If while editing in grid mode, changes are cancelled before receiving FIC
  response, it was possible to:
   - Create a new partial and incorrect line with only the data returned from
     FIC in case no line was being edited
   - Apply changes from FIC to incorrect row if another one was being edited

  Both problems are fixed by applying FIC changes only if the record is the same
  the request was triggered for, this is checked by ensuring both row number and
  record id. If editin a different record, FIC response is simply ignored.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0098043)
AugustoMauch (developer)
2017-07-12 12:01

Code reviewed and verified in pi@5a4d53a0947f

- Issue History
Date Modified Username Field Change
2017-07-11 13:03 alostale New Issue
2017-07-11 13:03 alostale Assigned To => platform
2017-07-11 13:03 alostale Modules => Core
2017-07-11 13:03 alostale Triggers an Emergency Pack => No
2017-07-11 13:04 alostale File Added: Selection_192.png
2017-07-11 13:14 alostale Steps to Reproduce Updated View Revisions
2017-07-11 13:15 alostale File Added: Selection_193.png
2017-07-11 13:15 alostale Steps to Reproduce Updated View Revisions
2017-07-11 13:15 alostale Relationship added related to 0036454
2017-07-11 13:17 alostale Assigned To platform => alostale
2017-07-11 13:33 ngarcia Issue Monitored: ngarcia
2017-07-11 14:58 alostale Relationship added related to 0036459
2017-07-12 08:18 alostale Status new => scheduled
2017-07-12 08:20 hgbot Checkin
2017-07-12 08:20 hgbot Note Added: 0098032
2017-07-12 08:20 hgbot Status scheduled => resolved
2017-07-12 08:20 hgbot Resolution open => fixed
2017-07-12 08:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5a4d53a0947fb4393d02af70ade0b4e911e88659 [^]
2017-07-12 08:34 alostale Review Assigned To => AugustoMauch
2017-07-12 10:11 AugustoMauch Description Updated View Revisions
2017-07-12 12:01 AugustoMauch Note Added: 0098043
2017-07-12 12:01 AugustoMauch Status resolved => closed
2017-07-12 12:01 AugustoMauch Fixed in Version => 3.0PR17Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker