Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0036437
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-07-06 13:442017-07-07 10:24
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q4
StatusclosedFix in branchFixed in SCM revision08518044d2b0
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036437: Avoid using Vector<Object> when only single type of data is used in the list (platform part)

DescriptionVector<Object> or any other of Object only make sense when planning to save several types of data inside the list.

When only stores i.e. Strings or objects of some other single class it does not make sense to use Vector<Object>:
- as no benefit
- harder to read + debug
- need extra casts when retrieving data

So this issue is about fixing simple cases which break this.

Note: Cases are selected as:
a.) simply fixable
b.) causing issues in latest release of some external code-checking tool (checkerframework)
Steps To Reproduce-
TagsNo tags attached.
Attached Filesdiff file icon vector-object-platform.diff [^] (16,098 bytes) 2017-07-06 13:44 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0036436 closedTriage Finance Avoid using Vector<Object> when only single type of data is used in the list (functional part) 

-  Notes
(0097911)
shuehner (administrator)
2017-07-06 13:45

Patch is compiled tested only. While mechanical simple changes only please check careful.
Note: Patch changes SqlC code-generator but for this change no need to update + re-commit all buildvalidations+modulescripts
(0097933)
hgbot (developer)
2017-07-07 10:22

Repository: erp/devel/pi
Changeset: 08518044d2b0f5f7d237f3fe54e4c78b3e4cb41a
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Jul 07 10:16:07 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/08518044d2b0f5f7d237f3fe54e4c78b3e4cb41a [^]

fixed 36437: Avoid using Vector<Object> when only single type of data is used

  In the cases when a single type of data is used, define Vector with the more
  specific type.

---
M src-core/src/org/openbravo/data/Sqlc.java
M src/org/openbravo/erpCommon/ad_actionButton/ActionButtonUtility.java
M src/org/openbravo/erpCommon/ad_forms/SQLExecutor_Query.java
M src/org/openbravo/erpCommon/ad_forms/ShowSessionVariables.java
M src/org/openbravo/erpCommon/ad_process/AlertProcess.java
M src/org/openbravo/erpCommon/businessUtility/Buscador.java
M src/org/openbravo/erpCommon/businessUtility/TabFilter.java
---
(0097935)
alostale (developer)
2017-07-07 10:24

reviewed

- Issue History
Date Modified Username Field Change
2017-07-06 13:44 shuehner New Issue
2017-07-06 13:44 shuehner Assigned To => platform
2017-07-06 13:44 shuehner Modules => Core
2017-07-06 13:44 shuehner Triggers an Emergency Pack => No
2017-07-06 13:44 shuehner Relationship added related to 0036436
2017-07-06 13:44 shuehner File Added: vector-object-platform.diff
2017-07-06 13:45 shuehner Note Added: 0097911
2017-07-07 10:16 alostale Assigned To platform => shuehner
2017-07-07 10:16 alostale Review Assigned To => alostale
2017-07-07 10:22 hgbot Checkin
2017-07-07 10:22 hgbot Note Added: 0097933
2017-07-07 10:22 hgbot Status new => resolved
2017-07-07 10:22 hgbot Resolution open => fixed
2017-07-07 10:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/08518044d2b0f5f7d237f3fe54e4c78b3e4cb41a [^]
2017-07-07 10:24 alostale Note Added: 0097935
2017-07-07 10:24 alostale Status resolved => closed
2017-07-07 10:24 alostale Fixed in Version => 3.0PR17Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker