Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036434
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-07-06 13:262017-09-21 16:49
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q4
StatusclosedFix in branchFixed in SCM revisionc557445d5d66
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toinigosanchez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036434: unlikely argument type warnings

DescriptionCompiling with ecj >= 3.13 (ie. using Eclipse Oxygen) some "unlikely argument" warnings can be found in code.
Steps To Reproduce1. Open openbravo with eclipse oxygen
2. Import standard openbravo preferences
3. Compile
  -> check warns:
# Eclipse Compiler for Java(TM) v20170516-1929, 3.13.0, Copyright IBM Corp 2000, 2015. All rights reserved.
----------
1. INFO in /home/alostale/ws/projects/license/openbravo/src/org/openbravo/dal/xml/EntityResolver.java (at line 363)
    if (refLoaded.getClientId().equals('0') && refLoaded.getOrgId().equals("0")) {
                                       ^^^
Unlikely argument type for equals(): char seems to be unrelated to String
----------
----------
9. WARNING in /home/alostale/ws/projects/license/openbravo/src/org/openbravo/service/web/UserContextCache.java (at line 111)
    cache.remove(ce);
                 ^^
Unlikely argument type UserContextCache.CacheEntry for remove(Object) on a Map<String,UserContextCache.CacheEntry>

----------
11. INFO in /home/alostale/ws/projects/license/openbravo/src-core/src/org/openbravo/base/VariablesBase.java (at line 1046)
    if (auxStr == null || auxStr.length == 0 || auxStr.equals("")) {
                                                              ^^
Unlikely argument type for equals(): String seems to be unrelated to String[]
----------
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0036435 closedmarkmm82 unlikely argument type warnings 

-  Notes
(0097917)
hgbot (developer)
2017-07-06 14:10

 Repository: erp/devel/pi
Changeset: c557445d5d662bd561d9f9658d771a978c0e43cc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jul 06 14:07:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c557445d5d662bd561d9f9658d771a978c0e43cc [^]

fixed bug 36434: unlikely argument type warnings

---
M src-core/src/org/openbravo/base/VariablesBase.java
M src/org/openbravo/dal/xml/EntityResolver.java
M src/org/openbravo/service/web/UserContextCache.java
---
(0098035)
hgbot (developer)
2017-07-12 09:21

 Repository: erp/mods/org.openbravo.utility.hqlquerytool
Changeset: 55cfdb938325c4a45e58431e89f405c507f6176d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 12 09:21:26 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.utility.hqlquerytool/rev/55cfdb938325c4a45e58431e89f405c507f6176d [^]

related to bug 36434: unlikely argument type warnings

---
M src/org/openbravo/utility/hqlquerytool/HQLQueryTool.java
---
(0098400)
inigosanchez (developer)
2017-08-04 14:49

 reviewed in pi@e6b6a636d1e4
(0099243)
hudsonbot (developer)
2017-09-21 16:49

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-07-06 13:26 alostale New Issue
2017-07-06 13:26 alostale Assigned To => platform
2017-07-06 13:26 alostale Modules => Core
2017-07-06 13:26 alostale Triggers an Emergency Pack => No
2017-07-06 13:28 alostale Issue cloned 0036435
2017-07-06 13:28 alostale Relationship added related to 0036435
2017-07-06 13:42 alostale Description Updated View Revisions
2017-07-06 14:07 alostale Assigned To platform => alostale
2017-07-06 14:07 alostale Review Assigned To => inigosanchez
2017-07-06 14:10 hgbot Checkin
2017-07-06 14:10 hgbot Note Added: 0097917
2017-07-06 14:10 hgbot Status new => resolved
2017-07-06 14:10 hgbot Resolution open => fixed
2017-07-06 14:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c557445d5d662bd561d9f9658d771a978c0e43cc [^]
2017-07-12 09:21 hgbot Checkin
2017-07-12 09:21 hgbot Note Added: 0098035
2017-08-04 14:49 inigosanchez Note Added: 0098400
2017-08-04 14:49 inigosanchez Status resolved => closed
2017-08-04 14:49 inigosanchez Fixed in Version => 3.0PR17Q4
2017-09-21 16:49 hudsonbot Checkin
2017-09-21 16:49 hudsonbot Note Added: 0099243

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker