Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036434Openbravo ERPA. Platformpublic2017-07-06 13:262017-09-21 16:49
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toinigosanchez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036434: unlikely argument type warnings
DescriptionCompiling with ecj >= 3.13 (ie. using Eclipse Oxygen) some "unlikely argument" warnings can be found in code.
Steps To Reproduce1. Open openbravo with eclipse oxygen
2. Import standard openbravo preferences
3. Compile
  -> check warns:
# Eclipse Compiler for Java(TM) v20170516-1929, 3.13.0, Copyright IBM Corp 2000, 2015. All rights reserved.
----------
1. INFO in /home/alostale/ws/projects/license/openbravo/src/org/openbravo/dal/xml/EntityResolver.java (at line 363)
    if (refLoaded.getClientId().equals('0') && refLoaded.getOrgId().equals("0")) {
                                       ^^^
Unlikely argument type for equals(): char seems to be unrelated to String
----------
----------
9. WARNING in /home/alostale/ws/projects/license/openbravo/src/org/openbravo/service/web/UserContextCache.java (at line 111)
    cache.remove(ce);
                 ^^
Unlikely argument type UserContextCache.CacheEntry for remove(Object) on a Map<String,UserContextCache.CacheEntry>

----------
11. INFO in /home/alostale/ws/projects/license/openbravo/src-core/src/org/openbravo/base/VariablesBase.java (at line 1046)
    if (auxStr == null || auxStr.length == 0 || auxStr.equals("")) {
                                                              ^^
Unlikely argument type for equals(): String seems to be unrelated to String[]
----------
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036435 closed markmm82 unlikely argument type warnings 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-07-06 13:26alostaleNew Issue
2017-07-06 13:26alostaleAssigned To => platform
2017-07-06 13:26alostaleModules => Core
2017-07-06 13:26alostaleTriggers an Emergency Pack => No
2017-07-06 13:28alostaleIssue cloned0036435
2017-07-06 13:28alostaleRelationship addedrelated to 0036435
2017-07-06 13:42alostaleDescription Updatedbug_revision_view_page.php?rev_id=15473#r15473
2017-07-06 14:07alostaleAssigned Toplatform => alostale
2017-07-06 14:07alostaleReview Assigned To => inigosanchez
2017-07-06 14:10hgbotCheckin
2017-07-06 14:10hgbotNote Added: 0097917
2017-07-06 14:10hgbotStatusnew => resolved
2017-07-06 14:10hgbotResolutionopen => fixed
2017-07-06 14:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c557445d5d662bd561d9f9658d771a978c0e43cc [^]
2017-07-12 09:21hgbotCheckin
2017-07-12 09:21hgbotNote Added: 0098035
2017-08-04 14:49inigosanchezNote Added: 0098400
2017-08-04 14:49inigosanchezStatusresolved => closed
2017-08-04 14:49inigosanchezFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099243

Notes
(0097917)
hgbot   
2017-07-06 14:10   
Repository: erp/devel/pi
Changeset: c557445d5d662bd561d9f9658d771a978c0e43cc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jul 06 14:07:15 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c557445d5d662bd561d9f9658d771a978c0e43cc [^]

fixed bug 36434: unlikely argument type warnings

---
M src-core/src/org/openbravo/base/VariablesBase.java
M src/org/openbravo/dal/xml/EntityResolver.java
M src/org/openbravo/service/web/UserContextCache.java
---
(0098035)
hgbot   
2017-07-12 09:21   
Repository: erp/mods/org.openbravo.utility.hqlquerytool
Changeset: 55cfdb938325c4a45e58431e89f405c507f6176d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 12 09:21:26 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.utility.hqlquerytool/rev/55cfdb938325c4a45e58431e89f405c507f6176d [^]

related to bug 36434: unlikely argument type warnings

---
M src/org/openbravo/utility/hqlquerytool/HQLQueryTool.java
---
(0098400)
inigosanchez   
2017-08-04 14:49   
reviewed in pi@e6b6a636d1e4
(0099243)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test