Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036369
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] StoreServermajorhave not tried2017-06-26 12:142017-08-02 15:42
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionf71ea8f6cabf
ProjectionnoneETAnoneTarget VersionRR17Q2.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036369: Incremental load does not call ready with loading in case of remote models in specific case

DescriptionThe normal logic of incremental load calls triggerRead [1] after each locally stored model is reloaded.
However in case of remote model [2] or other cases [3] triggerReady is not called.

The consequence of this is that if the last model in the queue is a remote model the loading popup remains visible and does not go away. See attached screenshot.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1606 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1619 [^]

[3]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1624 [^]
Steps To ReproduceSet remote product model
Install gift card module
Set incremental load to 2 minutes or so
Login, wait for incremental load to happen

Proposed SolutionCall triggerReady here [1] and remove it here [2]

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1564 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1606 [^]

TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0036332 closedmtaal Incremental load does not call ready with loading in case of remote models in specific case 

-  Notes
(0098025)
hgbot (developer)
2017-07-11 17:52

 Repository: retail/backports/3.0RR17Q2.2/org.openbravo.mobile.core
Changeset: f71ea8f6cabf1423d6dee13924c454364e62025b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jul 11 17:52:25 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.2/org.openbravo.mobile.core/rev/f71ea8f6cabf1423d6dee13924c454364e62025b [^]

Fixes issue 36369: Incremental load does not call ready with loading in case of remote models in specific case
Call triggerready only once at the end, solves async issue also

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0098343)
migueldejuana (viewer)
2017-08-02 15:42

 Tested and reviewed

- Issue History
Date Modified Username Field Change
2017-06-28 22:45 mtaal Type defect => backport
2017-06-28 22:45 mtaal Target Version RR17Q3 => RR17Q2.1
2017-07-11 17:31 mtaal Target Version RR17Q2.1 => RR17Q2.2
2017-07-11 17:51 mtaal Review Assigned To => migueldejuana
2017-07-11 17:51 mtaal Steps to Reproduce Updated View Revisions
2017-07-11 17:52 hgbot Checkin
2017-07-11 17:52 hgbot Note Added: 0098025
2017-07-11 17:52 hgbot Status scheduled => resolved
2017-07-11 17:52 hgbot Resolution open => fixed
2017-07-11 17:52 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR17Q2.2/org.openbravo.mobile.core/rev/f71ea8f6cabf1423d6dee13924c454364e62025b [^]
2017-08-02 15:42 migueldejuana Note Added: 0098343
2017-08-02 15:42 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker