Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036369Retail ModulesStoreServerpublic2017-06-26 12:142017-08-02 15:42
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2.2Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036369: Incremental load does not call ready with loading in case of remote models in specific case
DescriptionThe normal logic of incremental load calls triggerRead [1] after each locally stored model is reloaded.
However in case of remote model [2] or other cases [3] triggerReady is not called.

The consequence of this is that if the last model in the queue is a remote model the loading popup remains visible and does not go away. See attached screenshot.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1606 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1619 [^]

[3]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1624 [^]
Steps To ReproduceSet remote product model
Install gift card module
Set incremental load to 2 minutes or so
Login, wait for incremental load to happen

Proposed SolutionCall triggerReady here [1] and remove it here [2]

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1564 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/fbd548334939/web/org.openbravo.mobile.core/source/data/ob-dal.js#l1606 [^]

Additional Information
TagsNo tags attached.
Relationships
blocks defect 0036332 closed mtaal Incremental load does not call ready with loading in case of remote models in specific case 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-28 22:45mtaalTypedefect => backport
2017-06-28 22:45mtaalTarget VersionRR17Q3 => RR17Q2.1
2017-07-11 17:31mtaalTarget VersionRR17Q2.1 => RR17Q2.2
2017-07-11 17:51mtaalReview Assigned To => migueldejuana
2017-07-11 17:51mtaalSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=15489#r15489
2017-07-11 17:52hgbotCheckin
2017-07-11 17:52hgbotNote Added: 0098025
2017-07-11 17:52hgbotStatusscheduled => resolved
2017-07-11 17:52hgbotResolutionopen => fixed
2017-07-11 17:52hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR17Q2.2/org.openbravo.mobile.core/rev/f71ea8f6cabf1423d6dee13924c454364e62025b [^]
2017-08-02 15:42migueldejuanaNote Added: 0098343
2017-08-02 15:42migueldejuanaStatusresolved => closed

Notes
(0098025)
hgbot   
2017-07-11 17:52   
Repository: retail/backports/3.0RR17Q2.2/org.openbravo.mobile.core
Changeset: f71ea8f6cabf1423d6dee13924c454364e62025b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jul 11 17:52:25 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.2/org.openbravo.mobile.core/rev/f71ea8f6cabf1423d6dee13924c454364e62025b [^]

Fixes issue 36369: Incremental load does not call ready with loading in case of remote models in specific case
Call triggerready only once at the end, solves async issue also

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0098343)
migueldejuana   
2017-08-02 15:42   
Tested and reviewed