Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036250 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | have not tried | 2017-06-14 08:46 | 2017-06-16 19:02 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 921b3de9e420 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR17Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036250: Log if a stateless service creates a session | |||||||
| Description | The code here should be extended to log a warning message if a session was created during the service. [1] https://code.openbravo.com/erp/devel/pi/file/f33a32b03c29/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java#l365 [^] [2] https://code.openbravo.com/erp/devel/pi/file/f33a32b03c29/src/org/openbravo/service/web/BaseWebServiceServlet.java#l103 [^] | |||||||
| Steps To Reproduce | Run stateless webservice tests (part of retail test suite), in one of the stateless webservices forcefully create a session to check the session being created. | |||||||
| Proposed Solution | Check if a session is present before the logic, check that a session was created and if so then log a warning. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
Notes |
|
|
(0097383) hgbot (developer) 2017-06-14 08:48 |
Repository: erp/devel/pi Changeset: 921b3de9e420b62c8607e04d4f0a2ac154e81ed2 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Jun 14 08:48:29 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/921b3de9e420b62c8607e04d4f0a2ac154e81ed2 [^] Fixes issue 36250: Log if a stateless service creates a session Check if a session was present and if not if it got created, if so log a message --- M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java M src/org/openbravo/service/web/BaseWebServiceServlet.java --- |
|
(0097384) hgbot (developer) 2017-06-14 08:56 |
Repository: erp/devel/pi Changeset: 3640713e1a91a51ca08e03362ab0729eb3788897 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Jun 14 08:56:18 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/3640713e1a91a51ca08e03362ab0729eb3788897 [^] Related to issue 36250: Log if a stateless service creates a session Fix typo --- M src/org/openbravo/service/web/BaseWebServiceServlet.java --- |
|
(0097387) AugustoMauch (administrator) 2017-06-14 11:26 |
Code reviewed and verified |
|
(0097458) hudsonbot (viewer) 2017-06-16 19:02 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/38c05e8441a9 [^] Maturity status: Test |
|
(0097459) hudsonbot (viewer) 2017-06-16 19:02 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/38c05e8441a9 [^] Maturity status: Test |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-06-14 08:46 | mtaal | New Issue | |
| 2017-06-14 08:46 | mtaal | Assigned To | => mtaal |
| 2017-06-14 08:46 | mtaal | OBNetwork customer | => No |
| 2017-06-14 08:46 | mtaal | Modules | => Core |
| 2017-06-14 08:46 | mtaal | Triggers an Emergency Pack | => No |
| 2017-06-14 08:47 | mtaal | Relationship added | has duplicate 0036233 |
| 2017-06-14 08:47 | mtaal | Review Assigned To | => AugustoMauch |
| 2017-06-14 08:48 | mtaal | Steps to Reproduce Updated | View Revisions |
| 2017-06-14 08:48 | hgbot | Checkin | |
| 2017-06-14 08:48 | hgbot | Note Added: 0097383 | |
| 2017-06-14 08:48 | hgbot | Status | new => resolved |
| 2017-06-14 08:48 | hgbot | Resolution | open => fixed |
| 2017-06-14 08:48 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/921b3de9e420b62c8607e04d4f0a2ac154e81ed2 [^] |
| 2017-06-14 08:56 | hgbot | Checkin | |
| 2017-06-14 08:56 | hgbot | Note Added: 0097384 | |
| 2017-06-14 11:26 | AugustoMauch | Note Added: 0097387 | |
| 2017-06-14 11:26 | AugustoMauch | Status | resolved => closed |
| 2017-06-16 19:02 | hudsonbot | Checkin | |
| 2017-06-16 19:02 | hudsonbot | Note Added: 0097458 | |
| 2017-06-16 19:02 | hudsonbot | Checkin | |
| 2017-06-16 19:02 | hudsonbot | Note Added: 0097459 | |
| Copyright © 2000 - 2009 MantisBT Group |