Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0036250 | Openbravo ERP | A. Platform | public | 2017-06-14 08:46 | 2017-06-16 19:02 |
|
| Reporter | mtaal | |
| Assigned To | mtaal | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR17Q3 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0036250: Log if a stateless service creates a session |
| Description | The code here should be extended to log a warning message if a session was created during the service.
[1]
https://code.openbravo.com/erp/devel/pi/file/f33a32b03c29/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java#l365 [^]
[2]
https://code.openbravo.com/erp/devel/pi/file/f33a32b03c29/src/org/openbravo/service/web/BaseWebServiceServlet.java#l103 [^] |
| Steps To Reproduce | Run stateless webservice tests (part of retail test suite), in one of the stateless webservices forcefully create a session to check the session being created. |
| Proposed Solution | Check if a session is present before the logic, check that a session was created and if so then log a warning. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | has duplicate | design defect | 0036233 | RR17Q3 | closed | mtaal | Retail Modules | Log if a stateless service creates a session |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-06-14 08:46 | mtaal | New Issue | |
| 2017-06-14 08:46 | mtaal | Assigned To | => mtaal |
| 2017-06-14 08:46 | mtaal | OBNetwork customer | => No |
| 2017-06-14 08:46 | mtaal | Modules | => Core |
| 2017-06-14 08:46 | mtaal | Triggers an Emergency Pack | => No |
| 2017-06-14 08:47 | mtaal | Relationship added | has duplicate 0036233 |
| 2017-06-14 08:47 | mtaal | Review Assigned To | => AugustoMauch |
| 2017-06-14 08:48 | mtaal | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=15358#r15358 |
| 2017-06-14 08:48 | hgbot | Checkin | |
| 2017-06-14 08:48 | hgbot | Note Added: 0097383 | |
| 2017-06-14 08:48 | hgbot | Status | new => resolved |
| 2017-06-14 08:48 | hgbot | Resolution | open => fixed |
| 2017-06-14 08:48 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/921b3de9e420b62c8607e04d4f0a2ac154e81ed2 [^] |
| 2017-06-14 08:56 | hgbot | Checkin | |
| 2017-06-14 08:56 | hgbot | Note Added: 0097384 | |
| 2017-06-14 11:26 | AugustoMauch | Note Added: 0097387 | |
| 2017-06-14 11:26 | AugustoMauch | Status | resolved => closed |
| 2017-06-16 19:02 | hudsonbot | Checkin | |
| 2017-06-16 19:02 | hudsonbot | Note Added: 0097458 | |
| 2017-06-16 19:02 | hudsonbot | Checkin | |
| 2017-06-16 19:02 | hudsonbot | Note Added: 0097459 | |
|
Notes |
|
|
(0097383)
|
|
hgbot
|
|
2017-06-14 08:48
|
|
Repository: erp/devel/pi
Changeset: 921b3de9e420b62c8607e04d4f0a2ac154e81ed2
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 14 08:48:29 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/921b3de9e420b62c8607e04d4f0a2ac154e81ed2 [^]
Fixes issue 36250: Log if a stateless service creates a session
Check if a session was present and if not if it got created, if so log a message
---
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/service/web/BaseWebServiceServlet.java
---
|
|
|
|
(0097384)
|
|
hgbot
|
|
2017-06-14 08:56
|
|
|
|
|
|
|
Code reviewed and verified |
|
|
|
|
|
|
|
|
|