Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036212 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2017-06-08 17:14 | 2017-06-23 09:11 | |||
| Reporter | aaroncalero | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR17Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 0bc0da5851fa | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036212: Tickets removed on the cashup or the logout do not check for new payments added | |||||||
| Description | When a ticket is removed from web pos, a checking is done to verify that there are no new payments added to the receipt, in order to prevent losing these payments (which might have been done against a payment provider). This check only works when the removal of the ticket is done from the 'X' button, and it doesn't work when the ticket is removed either on a logout or on the 'Review pending receipts' step of the cashup. | |||||||
| Steps To Reproduce | Login in web pos Create a new ticket and add any product. Click on the total amount button to go to the payment tab. Add a payment. Click on the menu > Online > End Session > Log Out. >> The logout process is executed and the ticket is removed without warnings. Login again. Create a new ticket and add any product. Click on the total amount button to go to the payment tab. Add a payment. Click on the menu > Cashup The Review pending receipts step is shown Remove the opened ticket >> The ticket is removed without warnings. | |||||||
| Proposed Solution | The logic to verify if the ticket contains new payments should be moved to the generic deleteOrder function, which is called from all remove flows, instead of being on the code executed on the 'X' button. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0097268) marvintm (viewer) 2017-06-09 09:57 |
The best solution in this case is to move the validation of the existence of payments in a ticket which is going to be deleted to the deleteOrder function, so that it's always executed regardless of the flow which is trying to delete the ticket. |
|
(0097467) hgbot (developer) 2017-06-19 07:59 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 0bc0da5851fa9b2f90ca11492693042bdcfd9c14 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Jun 19 11:27:38 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bc0da5851fa9b2f90ca11492693042bdcfd9c14 [^] Fixed issue 36212 : Validate Payments while deleting tickets in cashup, logout, pay open tickets * Added "multiOrders" object to OB.MobileApp.model * Added "isMultiOrderState" attribute to to OB.MobileApp.model to check the current state --- M web/org.openbravo.retail.posterminal/js/closecash/view/tabpendingreceipts.js M web/org.openbravo.retail.posterminal/js/login/model/login-model.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js --- |
|
(0097468) hgbot (developer) 2017-06-19 07:59 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 0bc0da5851fa9b2f90ca11492693042bdcfd9c14 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Jun 19 11:27:38 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bc0da5851fa9b2f90ca11492693042bdcfd9c14 [^] Fixed issue 36212 : Validate Payments while deleting tickets in cashup, logout, pay open tickets * Added "multiOrders" object to OB.MobileApp.model * Added "isMultiOrderState" attribute to to OB.MobileApp.model to check the current state --- M web/org.openbravo.retail.posterminal/js/closecash/view/tabpendingreceipts.js M web/org.openbravo.retail.posterminal/js/login/model/login-model.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js --- |
|
(0097469) hgbot (developer) 2017-06-19 08:01 |
Repository: tools/automation/pi-mobile Changeset: ea4ac05f52efd7bad88f3c8c08a55ead4331fe8c Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Jun 19 11:28:53 2017 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ea4ac05f52efd7bad88f3c8c08a55ead4331fe8c [^] Verifies issue 36212 : Added automated test 'I36212_VerifyReceiptPaymentWhileDeleting' --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35022_VerifyDefaultTabOnLoad.java A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36212_VerifyReceiptPaymentWhileDeleting.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-06-08 17:14 | aaroncalero | New Issue | |
| 2017-06-08 17:14 | aaroncalero | Assigned To | => Retail |
| 2017-06-08 17:14 | aaroncalero | OBNetwork customer | => Yes |
| 2017-06-08 17:14 | aaroncalero | Resolution time | => 1498082400 |
| 2017-06-08 17:14 | aaroncalero | Triggers an Emergency Pack | => No |
| 2017-06-09 09:57 | marvintm | Note Added: 0097268 | |
| 2017-06-12 08:10 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2017-06-12 08:10 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-06-19 07:59 | hgbot | Checkin | |
| 2017-06-19 07:59 | hgbot | Note Added: 0097467 | |
| 2017-06-19 07:59 | hgbot | Status | scheduled => resolved |
| 2017-06-19 07:59 | hgbot | Resolution | open => fixed |
| 2017-06-19 07:59 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bc0da5851fa9b2f90ca11492693042bdcfd9c14 [^] |
| 2017-06-19 07:59 | hgbot | Checkin | |
| 2017-06-19 07:59 | hgbot | Note Added: 0097468 | |
| 2017-06-19 08:01 | hgbot | Checkin | |
| 2017-06-19 08:01 | hgbot | Note Added: 0097469 | |
| 2017-06-22 10:35 | marvintm | Review Assigned To | => marvintm |
| 2017-06-23 09:11 | marvintm | Status | resolved => closed |
| 2017-06-23 09:11 | marvintm | Fixed in Version | => RR17Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |