Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036212Retail ModulesWeb POSpublic2017-06-08 17:142017-06-23 09:11
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036212: Tickets removed on the cashup or the logout do not check for new payments added
DescriptionWhen a ticket is removed from web pos, a checking is done to verify that there are no new payments added to the receipt, in order to prevent losing these payments (which might have been done against a payment provider).
This check only works when the removal of the ticket is done from the 'X' button, and it doesn't work when the ticket is removed either on a logout or on the 'Review pending receipts' step of the cashup.
Steps To ReproduceLogin in web pos
Create a new ticket and add any product.
Click on the total amount button to go to the payment tab.
Add a payment.
Click on the menu > Online > End Session > Log Out.
>> The logout process is executed and the ticket is removed without warnings.
Login again.
Create a new ticket and add any product.
Click on the total amount button to go to the payment tab.
Add a payment.
Click on the menu > Cashup
The Review pending receipts step is shown
Remove the opened ticket
>> The ticket is removed without warnings.
Proposed SolutionThe logic to verify if the ticket contains new payments should be moved to the generic deleteOrder function, which is called from all remove flows, instead of being on the code executed on the 'X' button.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-08 17:14aaroncaleroNew Issue
2017-06-08 17:14aaroncaleroAssigned To => Retail
2017-06-08 17:14aaroncaleroResolution time => 1498082400
2017-06-08 17:14aaroncaleroTriggers an Emergency Pack => No
2017-06-09 09:57marvintmNote Added: 0097268
2017-06-12 08:10ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-06-12 08:10ranjith_qualiantech_comStatusnew => scheduled
2017-06-19 07:59hgbotCheckin
2017-06-19 07:59hgbotNote Added: 0097467
2017-06-19 07:59hgbotStatusscheduled => resolved
2017-06-19 07:59hgbotResolutionopen => fixed
2017-06-19 07:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bc0da5851fa9b2f90ca11492693042bdcfd9c14 [^]
2017-06-19 07:59hgbotCheckin
2017-06-19 07:59hgbotNote Added: 0097468
2017-06-19 08:01hgbotCheckin
2017-06-19 08:01hgbotNote Added: 0097469
2017-06-22 10:35marvintmReview Assigned To => marvintm
2017-06-23 09:11marvintmStatusresolved => closed
2017-06-23 09:11marvintmFixed in Version => RR17Q3

Notes
(0097268)
marvintm   
2017-06-09 09:57   
The best solution in this case is to move the validation of the existence of payments in a ticket which is going to be deleted to the deleteOrder function, so that it's always executed regardless of the flow which is trying to delete the ticket.
(0097467)
hgbot   
2017-06-19 07:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0bc0da5851fa9b2f90ca11492693042bdcfd9c14
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 19 11:27:38 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bc0da5851fa9b2f90ca11492693042bdcfd9c14 [^]

Fixed issue 36212 : Validate Payments while deleting tickets in cashup, logout, pay open tickets

* Added "multiOrders" object to OB.MobileApp.model
* Added "isMultiOrderState" attribute to to OB.MobileApp.model to check the current state

---
M web/org.openbravo.retail.posterminal/js/closecash/view/tabpendingreceipts.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0097468)
hgbot   
2017-06-19 07:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0bc0da5851fa9b2f90ca11492693042bdcfd9c14
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 19 11:27:38 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bc0da5851fa9b2f90ca11492693042bdcfd9c14 [^]

Fixed issue 36212 : Validate Payments while deleting tickets in cashup, logout, pay open tickets

* Added "multiOrders" object to OB.MobileApp.model
* Added "isMultiOrderState" attribute to to OB.MobileApp.model to check the current state

---
M web/org.openbravo.retail.posterminal/js/closecash/view/tabpendingreceipts.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0097469)
hgbot   
2017-06-19 08:01   
Repository: tools/automation/pi-mobile
Changeset: ea4ac05f52efd7bad88f3c8c08a55ead4331fe8c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 19 11:28:53 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ea4ac05f52efd7bad88f3c8c08a55ead4331fe8c [^]

Verifies issue 36212 : Added automated test 'I36212_VerifyReceiptPaymentWhileDeleting'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35022_VerifyDefaultTabOnLoad.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36212_VerifyReceiptPaymentWhileDeleting.java
---