Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036160
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2017-06-01 11:592017-06-26 10:52
ReportermalsasuaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revisiona99eaea6ebd2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket46774
Regression levelProduction - Confirmed Stable
Regression date2017-02-17
Regression introduced in releaseRR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb6b4b84a3416e104ee4aa2f2704ecaa732cc084 [^]
Triggers an Emergency PackNo
Summary

0036160: Discounts are not applied when a product is not included in the store assortment

Descriptionwhen a discount is configured with "included product: All excluding defined", and there is some product in product tab, then the discount is not applied for any product
Steps To Reproducein backend:
. discount and promotion window:
  . discount: GPS_10_per
  . change "included product" field, from "Only those defined" to "All excluding defined"
in product tab there are two products: gps handled and gps touch screen

in POS:
. add new product: inspect repelent
expected behavior: discount GPS_10_per should be applied, but it is not applied. It is not applied for any discount
Proposed Solutionin discount master query, this part should be removed:
    hql += "and ((p.includedProducts = 'Y' and not exists (select 1 ";
    hql += " from PricingAdjustmentProduct pap, OBRETCO_Prol_Product ppl ";
    hql += " where pap.active = true and pap.priceAdjustment = p ";
    hql += " and pap.product.id = ppl.product.id ";
    hql += " and ppl.obretcoProductlist.id ='" + productList.getId() + "')) ";
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0036231RR17Q2.1 closedranjith_qualiantech_com Discounts are not applied when a product is not included in the store assortment 
depends on backport 0036232RR17Q1.2 closedranjith_qualiantech_com Discounts are not applied when a product is not included in the store assortment 
caused by defect 0035254 closedranjith_qualiantech_com discount is not applied when some product is not included in assortment 

-  Notes
(0097320)
hgbot (developer)
2017-06-12 16:13

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a99eaea6ebd2ae64996cbbabdddf5e2d76131638
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 12 19:42:45 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a99eaea6ebd2ae64996cbbabdddf5e2d76131638 [^]

Fixed issue 36160 : Validate Discount Product if includeProduct is set as "all excluding defined"

* For Discount Product, if includeProduct is set as "all excluding defined" then it should not be checked with assortment

---
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0097321)
hgbot (developer)
2017-06-12 16:14

 Repository: tools/automation/pi-mobile
Changeset: f86a6cbf1ea6a207f4ee8016779f350aae159485
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 12 19:42:01 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f86a6cbf1ea6a207f4ee8016779f350aae159485 [^]

Verifies issue 36160 : Added automated test 'I36160_VerifyDiscountWithIncludeExcludeProducts'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I36160_VerifyDiscountWithIncludeExcludeProducts.java
---
(0097322)
ranjith_qualiantech_com (viewer)
2017-06-12 16:14

 Reopened to create backports

- Issue History
Date Modified Username Field Change
2017-06-01 11:59 malsasua New Issue
2017-06-01 11:59 malsasua Assigned To => Retail
2017-06-01 11:59 malsasua OBNetwork customer => Yes
2017-06-01 11:59 malsasua Support ticket => 46774
2017-06-01 11:59 malsasua Resolution time => 1498773600
2017-06-01 11:59 malsasua Regression level => Production - Confirmed Stable
2017-06-01 11:59 malsasua Triggers an Emergency Pack => No
2017-06-05 10:04 malsasua Relationship added related to 0035254
2017-06-08 09:22 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2017-06-08 09:22 ranjith_qualiantech_com Status new => scheduled
2017-06-12 08:04 ranjith_qualiantech_com Regression date => 2017-02-17
2017-06-12 08:04 ranjith_qualiantech_com Regression introduced in release => RR17Q2
2017-06-12 08:04 ranjith_qualiantech_com Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb6b4b84a3416e104ee4aa2f2704ecaa732cc084 [^]
2017-06-12 16:13 hgbot Checkin
2017-06-12 16:13 hgbot Note Added: 0097320
2017-06-12 16:13 hgbot Status scheduled => resolved
2017-06-12 16:13 hgbot Resolution open => fixed
2017-06-12 16:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a99eaea6ebd2ae64996cbbabdddf5e2d76131638 [^]
2017-06-12 16:14 hgbot Checkin
2017-06-12 16:14 hgbot Note Added: 0097321
2017-06-12 16:14 ranjith_qualiantech_com Note Added: 0097322
2017-06-12 16:14 ranjith_qualiantech_com Status resolved => new
2017-06-12 16:14 ranjith_qualiantech_com Resolution fixed => open
2017-06-12 16:15 ranjith_qualiantech_com Status new => scheduled
2017-06-12 16:15 ranjith_qualiantech_com Status scheduled => resolved
2017-06-12 16:15 ranjith_qualiantech_com Resolution open => fixed
2017-06-19 18:29 marvintm Review Assigned To => marvintm
2017-06-19 18:29 marvintm Status resolved => closed
2017-06-19 18:29 marvintm Fixed in Version => RR17Q3
2017-06-26 10:52 dmitry_mezentsev Relationship replaced caused by 0035254

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker