Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036160Retail ModulesDiscounts and Promotionspublic2017-06-01 11:592017-06-26 10:52
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-02-17
Regression introduced in releaseRR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb6b4b84a3416e104ee4aa2f2704ecaa732cc084 [^]
Triggers an Emergency PackNo
Summary0036160: Discounts are not applied when a product is not included in the store assortment
Descriptionwhen a discount is configured with "included product: All excluding defined", and there is some product in product tab, then the discount is not applied for any product
Steps To Reproducein backend:
. discount and promotion window:
  . discount: GPS_10_per
  . change "included product" field, from "Only those defined" to "All excluding defined"
in product tab there are two products: gps handled and gps touch screen

in POS:
. add new product: inspect repelent
expected behavior: discount GPS_10_per should be applied, but it is not applied. It is not applied for any discount
Proposed Solutionin discount master query, this part should be removed:
    hql += "and ((p.includedProducts = 'Y' and not exists (select 1 ";
    hql += " from PricingAdjustmentProduct pap, OBRETCO_Prol_Product ppl ";
    hql += " where pap.active = true and pap.priceAdjustment = p ";
    hql += " and pap.product.id = ppl.product.id ";
    hql += " and ppl.obretcoProductlist.id ='" + productList.getId() + "')) ";
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0036231RR17Q2.1 closed ranjith_qualiantech_com Discounts are not applied when a product is not included in the store assortment 
depends on backport 0036232RR17Q1.2 closed ranjith_qualiantech_com Discounts are not applied when a product is not included in the store assortment 
caused by defect 0035254 closed ranjith_qualiantech_com discount is not applied when some product is not included in assortment 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-01 11:59malsasuaNew Issue
2017-06-01 11:59malsasuaAssigned To => Retail
2017-06-01 11:59malsasuaResolution time => 1498773600
2017-06-01 11:59malsasuaRegression level => Production - Confirmed Stable
2017-06-01 11:59malsasuaTriggers an Emergency Pack => No
2017-06-05 10:04malsasuaRelationship addedrelated to 0035254
2017-06-08 09:22ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-06-08 09:22ranjith_qualiantech_comStatusnew => scheduled
2017-06-12 08:04ranjith_qualiantech_comRegression date => 2017-02-17
2017-06-12 08:04ranjith_qualiantech_comRegression introduced in release => RR17Q2
2017-06-12 08:04ranjith_qualiantech_comRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb6b4b84a3416e104ee4aa2f2704ecaa732cc084 [^]
2017-06-12 16:13hgbotCheckin
2017-06-12 16:13hgbotNote Added: 0097320
2017-06-12 16:13hgbotStatusscheduled => resolved
2017-06-12 16:13hgbotResolutionopen => fixed
2017-06-12 16:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a99eaea6ebd2ae64996cbbabdddf5e2d76131638 [^]
2017-06-12 16:14hgbotCheckin
2017-06-12 16:14hgbotNote Added: 0097321
2017-06-12 16:14ranjith_qualiantech_comNote Added: 0097322
2017-06-12 16:14ranjith_qualiantech_comStatusresolved => new
2017-06-12 16:14ranjith_qualiantech_comResolutionfixed => open
2017-06-12 16:15ranjith_qualiantech_comStatusnew => scheduled
2017-06-12 16:15ranjith_qualiantech_comStatusscheduled => resolved
2017-06-12 16:15ranjith_qualiantech_comResolutionopen => fixed
2017-06-19 18:29marvintmReview Assigned To => marvintm
2017-06-19 18:29marvintmStatusresolved => closed
2017-06-19 18:29marvintmFixed in Version => RR17Q3
2017-06-26 10:52dmitry_mezentsevRelationship replacedcaused by 0035254

Notes
(0097320)
hgbot   
2017-06-12 16:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a99eaea6ebd2ae64996cbbabdddf5e2d76131638
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 12 19:42:45 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a99eaea6ebd2ae64996cbbabdddf5e2d76131638 [^]

Fixed issue 36160 : Validate Discount Product if includeProduct is set as "all excluding defined"

* For Discount Product, if includeProduct is set as "all excluding defined" then it should not be checked with assortment

---
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0097321)
hgbot   
2017-06-12 16:14   
Repository: tools/automation/pi-mobile
Changeset: f86a6cbf1ea6a207f4ee8016779f350aae159485
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 12 19:42:01 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f86a6cbf1ea6a207f4ee8016779f350aae159485 [^]

Verifies issue 36160 : Added automated test 'I36160_VerifyDiscountWithIncludeExcludeProducts'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I36160_VerifyDiscountWithIncludeExcludeProducts.java
---
(0097322)
ranjith_qualiantech_com   
2017-06-12 16:14   
Reopened to create backports