Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036011
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-05-16 13:352017-08-07 15:08
ReporterasiermartirenaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revision769c19a990da
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036011: Is possible to return money with a payment method with refundable = 'N'

DescriptionIs possible to return money with a payment method that is configured to be not refundable.

Now, this check is done for those tickets that have a negative gross, but there are some situations in which the gross is positive but the payments will be negative, or in which is positive and the payments must be negative.

Void Layaway, Cancel Layaway and Cancel and Replace which is returning money are three examples.

Instead of checking the gross, is necessary to check the isNegative property of the paymentStatus.
Steps To ReproduceSet a payment method as not refundable.
Load the Web POS.
Create a layaway and paid it partially.
Cancel or void the layaway.
Pay with the configured payment method.

This payment shouldn't be allowed.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0036012 closedranjith_qualiantech_com Is possible to return with a payment not refundable 

-  Notes
(0097656)
hgbot (developer)
2017-06-26 14:25

 Repository: tools/automation/pi-mobile
Changeset: 5ea7f2dcdaf168aee6ca7b123ebc49468699369d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 26 17:53:16 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5ea7f2dcdaf168aee6ca7b123ebc49468699369d [^]

Verifies issue 36011 : Modified automated test 'I35995_VerifyRefundablePaymentMethod'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I35995_VerifyRefundablePaymentMethod.java
---
(0097657)
hgbot (developer)
2017-06-26 14:25

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 812ed78da74225deff702d6bbfa90e682a1a2aa9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 26 17:54:35 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/812ed78da74225deff702d6bbfa90e682a1a2aa9 [^]

Fixed issue 36011 : Non-Refundable payments should be disabled/hidden if the receipt payment status is negative

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0097705)
marvintm (manager)
2017-06-27 12:12

 Currently in the fix we are checking two conditions:
- this.model.get('order').getTotal() < 0
- this.model.get('order').getPaymentStatus().isNegative

but although it currently works in all cases, the first one is now redundant, as the isNegative status already checks the whole payment status, and it's the only relevant thing here, so the first condition should be removed for greater clarity
(0097815)
hgbot (developer)
2017-07-04 08:51

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 769c19a990dab69cfc66d41420873554ba3e694a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jul 04 12:20:27 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/769c19a990dab69cfc66d41420873554ba3e694a [^]

Fixed issue 36011 : Removed unused code for validating receipt status

* If receipt payment is negative, it should be checked with receipt payment status instead of receipt total

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0098410)
jorge-garcia (reporter)
2017-08-07 15:08

 Review and tested

- Issue History
Date Modified Username Field Change
2017-05-16 13:35 asiermartirena New Issue
2017-05-16 13:35 asiermartirena Assigned To => Retail
2017-05-16 13:35 asiermartirena Triggers an Emergency Pack => No
2017-05-16 14:00 asiermartirena Relationship added blocks 0036012
2017-06-19 11:45 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2017-06-19 16:21 ranjith_qualiantech_com Status new => scheduled
2017-06-26 14:25 hgbot Checkin
2017-06-26 14:25 hgbot Note Added: 0097656
2017-06-26 14:25 hgbot Checkin
2017-06-26 14:25 hgbot Note Added: 0097657
2017-06-26 14:25 hgbot Status scheduled => resolved
2017-06-26 14:25 hgbot Resolution open => fixed
2017-06-26 14:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/812ed78da74225deff702d6bbfa90e682a1a2aa9 [^]
2017-06-27 12:12 marvintm Note Added: 0097705
2017-06-27 12:12 marvintm Status resolved => new
2017-06-27 12:12 marvintm Resolution fixed => open
2017-06-27 12:57 ranjith_qualiantech_com Status new => scheduled
2017-07-04 08:51 hgbot Checkin
2017-07-04 08:51 hgbot Note Added: 0097815
2017-07-04 08:51 hgbot Status scheduled => resolved
2017-07-04 08:51 hgbot Resolution open => fixed
2017-07-04 08:51 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/812ed78da74225deff702d6bbfa90e682a1a2aa9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/769c19a990dab69cfc66d41420873554ba3e694a [^]
2017-08-07 14:12 jorge-garcia Review Assigned To => jorge-garcia
2017-08-07 15:08 jorge-garcia Note Added: 0098410
2017-08-07 15:08 jorge-garcia Status resolved => closed
2017-08-07 15:08 jorge-garcia Fixed in Version => RR17Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker