Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036011Retail ModulesWeb POSpublic2017-05-16 13:352017-08-07 15:08
Reporterasiermartirena 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036011: Is possible to return money with a payment method with refundable = 'N'
DescriptionIs possible to return money with a payment method that is configured to be not refundable.

Now, this check is done for those tickets that have a negative gross, but there are some situations in which the gross is positive but the payments will be negative, or in which is positive and the payments must be negative.

Void Layaway, Cancel Layaway and Cancel and Replace which is returning money are three examples.

Instead of checking the gross, is necessary to check the isNegative property of the paymentStatus.
Steps To ReproduceSet a payment method as not refundable.
Load the Web POS.
Create a layaway and paid it partially.
Cancel or void the layaway.
Pay with the configured payment method.

This payment shouldn't be allowed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0036012 closed ranjith_qualiantech_com Is possible to return with a payment not refundable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-16 13:35asiermartirenaNew Issue
2017-05-16 13:35asiermartirenaAssigned To => Retail
2017-05-16 13:35asiermartirenaTriggers an Emergency Pack => No
2017-05-16 14:00asiermartirenaRelationship addedblocks 0036012
2017-06-19 11:45ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-06-19 16:21ranjith_qualiantech_comStatusnew => scheduled
2017-06-26 14:25hgbotCheckin
2017-06-26 14:25hgbotNote Added: 0097656
2017-06-26 14:25hgbotCheckin
2017-06-26 14:25hgbotNote Added: 0097657
2017-06-26 14:25hgbotStatusscheduled => resolved
2017-06-26 14:25hgbotResolutionopen => fixed
2017-06-26 14:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/812ed78da74225deff702d6bbfa90e682a1a2aa9 [^]
2017-06-27 12:12marvintmNote Added: 0097705
2017-06-27 12:12marvintmStatusresolved => new
2017-06-27 12:12marvintmResolutionfixed => open
2017-06-27 12:57ranjith_qualiantech_comStatusnew => scheduled
2017-07-04 08:51hgbotCheckin
2017-07-04 08:51hgbotNote Added: 0097815
2017-07-04 08:51hgbotStatusscheduled => resolved
2017-07-04 08:51hgbotResolutionopen => fixed
2017-07-04 08:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/812ed78da74225deff702d6bbfa90e682a1a2aa9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/769c19a990dab69cfc66d41420873554ba3e694a [^]
2017-08-07 14:12jorge-garciaReview Assigned To => jorge-garcia
2017-08-07 15:08jorge-garciaNote Added: 0098410
2017-08-07 15:08jorge-garciaStatusresolved => closed
2017-08-07 15:08jorge-garciaFixed in Version => RR17Q4

Notes
(0097656)
hgbot   
2017-06-26 14:25   
Repository: tools/automation/pi-mobile
Changeset: 5ea7f2dcdaf168aee6ca7b123ebc49468699369d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 26 17:53:16 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5ea7f2dcdaf168aee6ca7b123ebc49468699369d [^]

Verifies issue 36011 : Modified automated test 'I35995_VerifyRefundablePaymentMethod'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I35995_VerifyRefundablePaymentMethod.java
---
(0097657)
hgbot   
2017-06-26 14:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 812ed78da74225deff702d6bbfa90e682a1a2aa9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 26 17:54:35 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/812ed78da74225deff702d6bbfa90e682a1a2aa9 [^]

Fixed issue 36011 : Non-Refundable payments should be disabled/hidden if the receipt payment status is negative

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0097705)
marvintm   
2017-06-27 12:12   
Currently in the fix we are checking two conditions:
- this.model.get('order').getTotal() < 0
- this.model.get('order').getPaymentStatus().isNegative

but although it currently works in all cases, the first one is now redundant, as the isNegative status already checks the whole payment status, and it's the only relevant thing here, so the first condition should be removed for greater clarity
(0097815)
hgbot   
2017-07-04 08:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 769c19a990dab69cfc66d41420873554ba3e694a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jul 04 12:20:27 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/769c19a990dab69cfc66d41420873554ba3e694a [^]

Fixed issue 36011 : Removed unused code for validating receipt status

* If receipt payment is negative, it should be checked with receipt payment status instead of receipt total

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0098410)
jorge-garcia   
2017-08-07 15:08   
Review and tested