Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036009
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2017-05-16 13:032017-06-08 10:04
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in Version3.0PR17Q3
StatusclosedFix in branchFixed in SCM revision4ac217114d34
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036009: Product selector in Stock Report is not working when using Tomcat 7.0.76 or higher

DescriptionProduct selector in Stock Report is not working when using Tomcat 7.0.76 or higher. The following error stack trace is shown after opening the selector pop-up:

java.lang.ClassCastException: org.apache.catalina.util.ParameterMap cannot be cast to java.util.HashMap
    at org.openbravo.erpCommon.info.ProductMultiple.isCalledFromSoTrx(ProductMultiple.java:437)
    at org.openbravo.erpCommon.info.ProductMultiple.doPost(ProductMultiple.java:72)
    at org.openbravo.base.HttpBaseServlet.doGet(HttpBaseServlet.java:294)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:624)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:455)

This is caused due to a change introduced in Tomcat 7.0.76[1]. The ParameterMap[2] class is no longer extending HashMap.

[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=60808 [^]
[2] https://github.com/apache/tomcat/commit/4e6c21d4f2fef36885d9f4945b31c38c30a95adf#diff-f426585723df91288b2aec48c27124e2 [^]
Steps To Reproduce1) Deploy Openbravo in Tomcat 7.0.76 or higher
2) Open the [Stock Report] window
3) Open the Product selector pop-up
Proposed SolutionDo not perform the cast to HashMap with this expression: request.getParameterMap().
TagsNo tags attached.
Attached Filespng file icon classCastException.png [^] (27,699 bytes) 2017-05-16 13:03

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00221663.0MP21 closedioritzCia Wrong behaviour in the product selector of 'Product selector' in Sales order reports 

-  Notes
(0096620)
hgbot (developer)
2017-05-16 13:31

 Repository: erp/devel/pi
Changeset: 4ac217114d34d44f7c5e4e6ff770a685e9afe65b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue May 16 13:28:29 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4ac217114d34d44f7c5e4e6ff770a685e9afe65b [^]

fixes bug 36009: Manual product selector not working in Tomcat 7.0.76 or higher

Several improvements in isCalledFromSoTrx method:
- Avoid unnecessary casting to HashMap to fix the issue
- Use enhanced for-loop instead of using Iterator
- Return the result directly when the "issotrx" parameter is found

---
M src/org/openbravo/erpCommon/info/ProductMultiple.java
---
(0096623)
hgbot (developer)
2017-05-16 17:17

 Repository: erp/devel/pi
Changeset: f2ce1dbf54a3d2d65149e10ab4ff395e2357b707
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue May 16 17:16:27 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f2ce1dbf54a3d2d65149e10ab4ff395e2357b707 [^]

Related to issue 36009: Update copyright year

---
M src/org/openbravo/erpCommon/info/ProductMultiple.java
---
(0096625)
aferraz (manager)
2017-05-16 18:05

 Code review + Testing OK
(0096968)
hudsonbot (developer)
2017-05-29 17:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096970)
hudsonbot (developer)
2017-05-29 17:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-05-16 13:03 caristu New Issue
2017-05-16 13:03 caristu Assigned To => platform
2017-05-16 13:03 caristu Modules => Core
2017-05-16 13:03 caristu Triggers an Emergency Pack => No
2017-05-16 13:03 caristu File Added: classCastException.png
2017-05-16 13:03 caristu Relationship added related to 0022166
2017-05-16 13:04 caristu Proposed Solution updated
2017-05-16 13:05 caristu Description Updated View Revisions
2017-05-16 13:07 caristu Description Updated View Revisions
2017-05-16 13:10 caristu Description Updated View Revisions
2017-05-16 13:10 caristu Description Updated View Revisions
2017-05-16 13:11 caristu Description Updated View Revisions
2017-05-16 13:18 caristu Description Updated View Revisions
2017-05-16 13:30 caristu Assigned To platform => caristu
2017-05-16 13:31 hgbot Checkin
2017-05-16 13:31 hgbot Note Added: 0096620
2017-05-16 13:31 hgbot Status new => resolved
2017-05-16 13:31 hgbot Resolution open => fixed
2017-05-16 13:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4ac217114d34d44f7c5e4e6ff770a685e9afe65b [^]
2017-05-16 13:31 caristu Category A. Platform => 07. Sales management
2017-05-16 13:32 caristu Review Assigned To => aferraz
2017-05-16 17:17 hgbot Checkin
2017-05-16 17:17 hgbot Note Added: 0096623
2017-05-16 18:05 aferraz Note Added: 0096625
2017-05-16 18:05 aferraz Status resolved => closed
2017-05-16 18:05 aferraz Fixed in Version => 3.0PR17Q3
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096968
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096970
2017-06-08 10:00 alostale Relationship added related to 0036192
2017-06-08 10:04 alostale Relationship deleted related to 0036192

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker