Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0036009 | Openbravo ERP | 07. Sales management | public | 2017-05-16 13:03 | 2017-06-08 10:04 |
|
| Reporter | caristu | |
| Assigned To | caristu | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR17Q3 | |
| Merge Request Status | |
| Review Assigned To | aferraz |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0036009: Product selector in Stock Report is not working when using Tomcat 7.0.76 or higher |
| Description | Product selector in Stock Report is not working when using Tomcat 7.0.76 or higher. The following error stack trace is shown after opening the selector pop-up:
java.lang.ClassCastException: org.apache.catalina.util.ParameterMap cannot be cast to java.util.HashMap
at org.openbravo.erpCommon.info.ProductMultiple.isCalledFromSoTrx(ProductMultiple.java:437)
at org.openbravo.erpCommon.info.ProductMultiple.doPost(ProductMultiple.java:72)
at org.openbravo.base.HttpBaseServlet.doGet(HttpBaseServlet.java:294)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:624)
at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228)
at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:455)
This is caused due to a change introduced in Tomcat 7.0.76[1]. The ParameterMap[2] class is no longer extending HashMap.
[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=60808 [^]
[2] https://github.com/apache/tomcat/commit/4e6c21d4f2fef36885d9f4945b31c38c30a95adf#diff-f426585723df91288b2aec48c27124e2 [^] |
| Steps To Reproduce | 1) Deploy Openbravo in Tomcat 7.0.76 or higher
2) Open the [Stock Report] window
3) Open the Product selector pop-up |
| Proposed Solution | Do not perform the cast to HashMap with this expression: request.getParameterMap(). |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0022166 | 3.0MP21 | closed | ioritzCia | Wrong behaviour in the product selector of 'Product selector' in Sales order reports |
|
| Attached Files |  classCastException.png (27,699) 2017-05-16 13:03
https://issues.openbravo.com/file_download.php?file_id=10763&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2017-05-16 13:03 | caristu | New Issue | |
| 2017-05-16 13:03 | caristu | Assigned To | => platform |
| 2017-05-16 13:03 | caristu | OBNetwork customer | => No |
| 2017-05-16 13:03 | caristu | Modules | => Core |
| 2017-05-16 13:03 | caristu | Triggers an Emergency Pack | => No |
| 2017-05-16 13:03 | caristu | File Added: classCastException.png | |
| 2017-05-16 13:03 | caristu | Relationship added | related to 0022166 |
| 2017-05-16 13:04 | caristu | Proposed Solution updated | |
| 2017-05-16 13:05 | caristu | Description Updated | bug_revision_view_page.php?rev_id=15173#r15173 |
| 2017-05-16 13:07 | caristu | Description Updated | bug_revision_view_page.php?rev_id=15174#r15174 |
| 2017-05-16 13:10 | caristu | Description Updated | bug_revision_view_page.php?rev_id=15175#r15175 |
| 2017-05-16 13:10 | caristu | Description Updated | bug_revision_view_page.php?rev_id=15176#r15176 |
| 2017-05-16 13:11 | caristu | Description Updated | bug_revision_view_page.php?rev_id=15177#r15177 |
| 2017-05-16 13:18 | caristu | Description Updated | bug_revision_view_page.php?rev_id=15178#r15178 |
| 2017-05-16 13:30 | caristu | Assigned To | platform => caristu |
| 2017-05-16 13:31 | hgbot | Checkin | |
| 2017-05-16 13:31 | hgbot | Note Added: 0096620 | |
| 2017-05-16 13:31 | hgbot | Status | new => resolved |
| 2017-05-16 13:31 | hgbot | Resolution | open => fixed |
| 2017-05-16 13:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/4ac217114d34d44f7c5e4e6ff770a685e9afe65b [^] |
| 2017-05-16 13:31 | caristu | Category | A. Platform => 07. Sales management |
| 2017-05-16 13:32 | caristu | Review Assigned To | => aferraz |
| 2017-05-16 17:17 | hgbot | Checkin | |
| 2017-05-16 17:17 | hgbot | Note Added: 0096623 | |
| 2017-05-16 18:05 | aferraz | Note Added: 0096625 | |
| 2017-05-16 18:05 | aferraz | Status | resolved => closed |
| 2017-05-16 18:05 | aferraz | Fixed in Version | => 3.0PR17Q3 |
| 2017-05-29 17:43 | hudsonbot | Checkin | |
| 2017-05-29 17:43 | hudsonbot | Note Added: 0096968 | |
| 2017-05-29 17:43 | hudsonbot | Checkin | |
| 2017-05-29 17:43 | hudsonbot | Note Added: 0096970 | |
| 2017-06-08 10:00 | alostale | Relationship added | related to 0036192 |
| 2017-06-08 10:04 | alostale | Relationship deleted | related to 0036192 |
|
Notes |
|
|
(0096620)
|
|
hgbot
|
|
2017-05-16 13:31
|
|
Repository: erp/devel/pi
Changeset: 4ac217114d34d44f7c5e4e6ff770a685e9afe65b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue May 16 13:28:29 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4ac217114d34d44f7c5e4e6ff770a685e9afe65b [^]
fixes bug 36009: Manual product selector not working in Tomcat 7.0.76 or higher
Several improvements in isCalledFromSoTrx method:
- Avoid unnecessary casting to HashMap to fix the issue
- Use enhanced for-loop instead of using Iterator
- Return the result directly when the "issotrx" parameter is found
---
M src/org/openbravo/erpCommon/info/ProductMultiple.java
---
|
|
|
|
(0096623)
|
|
hgbot
|
|
2017-05-16 17:17
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|