Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036007 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2017-05-16 12:16 | 2017-06-02 14:56 | |||
| Reporter | aaroncalero | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR17Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d1c919bcc912 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036007: Return documentNo is not being set when service quantity rules are being applied | |||||||
| Description | When the return document sequence in configured, when all lines in a ticket are negative the document number of the ticket is changed to follow the return sequence. When a ticket contains a product and a related service, and the product is returned using the Return Line option, the service quantity rules are triggered and the service is also returned. However when this happens the document number of the ticket is not updated and it still shows the ticket sequence (instead of the return sequence). | |||||||
| Steps To Reproduce | Login in backend, go to the POS Terminal window, find the VBS-1 record and configure a Return No Prefix (i.e. VBSRET1). Login in web pos. Create a new ticket. Add an Avalanche transceiver classic and a Phone consulting MK2 related to it. Click on the Avalanche transceiver classic line and then on Return Line. The Phone consulting MK2 qty will also change to -1, however the document number of the ticket will remain with the standard sequence. Select the Phone consulting MK2 line and delete it. Now the document number will correctly show the return document sequence. | |||||||
| Proposed Solution | The main logic to change the document sequence from tickets to returns is placed inside the code that is also in charge of applying the quantity rules for services[1]. This code is protected against parallel executions using several control flags. When the quantity rules are triggered, and the ticket changes into a negative ticket, the control flags prevent a new execution of the code, so the document change logic is not executed. The document change logic should be placed either outside the "controlled code", or in a different handler to prevent these situations. [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/cd13ce1880ca/web/org.openbravo.retail.posterminal/js/components/order.js#l706 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0096681) hgbot (developer) 2017-05-19 11:48 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d1c919bcc91234e41caa589104776b85ad51e007 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri May 19 15:18:01 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d1c919bcc91234e41caa589104776b85ad51e007 [^] Fixed issue 36007 : Return DocumentNo should be updated whenever receipt line properties changed * New Listener created for Order line to check documentNo --- M web/org.openbravo.retail.posterminal/js/components/order.js --- |
|
(0096682) hgbot (developer) 2017-05-19 11:49 |
Repository: tools/automation/pi-mobile Changeset: 62f5b9a6e9fde24adf05784211595d19a2edd94a Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri May 19 15:15:32 2017 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/62f5b9a6e9fde24adf05784211595d19a2edd94a [^] Verifies issue 36007 : Added automated test 'I36007_VerifiedReturnsDocumentNoWithServices' --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I36007_VerifiedReturnsDocumentNoWithServices.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-05-16 12:16 | aaroncalero | New Issue | |
| 2017-05-16 12:16 | aaroncalero | Assigned To | => Retail |
| 2017-05-16 12:16 | aaroncalero | OBNetwork customer | => Yes |
| 2017-05-16 12:16 | aaroncalero | Resolution time | => 1496095200 |
| 2017-05-16 12:16 | aaroncalero | Triggers an Emergency Pack | => No |
| 2017-05-17 12:54 | ranjith_qualiantech_com | Relationship added | related to 0035971 |
| 2017-05-17 14:38 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2017-05-17 14:38 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-05-19 11:48 | hgbot | Checkin | |
| 2017-05-19 11:48 | hgbot | Note Added: 0096681 | |
| 2017-05-19 11:48 | hgbot | Status | scheduled => resolved |
| 2017-05-19 11:48 | hgbot | Resolution | open => fixed |
| 2017-05-19 11:48 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d1c919bcc91234e41caa589104776b85ad51e007 [^] |
| 2017-05-19 11:49 | hgbot | Checkin | |
| 2017-05-19 11:49 | hgbot | Note Added: 0096682 | |
| 2017-06-02 14:56 | marvintm | Review Assigned To | => marvintm |
| 2017-06-02 14:56 | marvintm | Status | resolved => closed |
| 2017-06-02 14:56 | marvintm | Fixed in Version | => RR17Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |