0036007: Return documentNo is not being set when service quantity rules are being applied

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036007

Retail Modules

Web POS

public

2017-05-16 12:16

2017-06-02 14:56

Reporter

aaroncalero

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR17Q3

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0036007: Return documentNo is not being set when service quantity rules are being applied

Description

When the return document sequence in configured, when all lines in a ticket are negative the document number of the ticket is changed to follow the return sequence.
When a ticket contains a product and a related service, and the product is returned using the Return Line option, the service quantity rules are triggered and the service is also returned. However when this happens the document number of the ticket is not updated and it still shows the ticket sequence (instead of the return sequence).

Steps To Reproduce

Login in backend, go to the POS Terminal window, find the VBS-1 record and configure a Return No Prefix (i.e. VBSRET1).

Login in web pos.
Create a new ticket.
Add an Avalanche transceiver classic and a Phone consulting MK2 related to it.
Click on the Avalanche transceiver classic line and then on Return Line.
The Phone consulting MK2 qty will also change to -1, however the document number of the ticket will remain with the standard sequence.
Select the Phone consulting MK2 line and delete it. Now the document number will correctly show the return document sequence.

Proposed Solution

The main logic to change the document sequence from tickets to returns is placed inside the code that is also in charge of applying the quantity rules for services[1].
This code is protected against parallel executions using several control flags.
When the quantity rules are triggered, and the ticket changes into a negative ticket, the control flags prevent a new execution of the code, so the document change logic is not executed.
The document change logic should be placed either outside the "controlled code", or in a different handler to prevent these situations.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/cd13ce1880ca/web/org.openbravo.retail.posterminal/js/components/order.js#l706 [^]

Additional Information