Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035994
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. PlatformminorN/A2017-05-15 11:362017-05-31 15:23
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in Version3.0PR17Q3
StatusclosedFix in branchFixed in SCM revision383058dac569
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035994: Web service calls should not create ad_session entries being in an instance with unlimited web service calls

DescriptionCurrently every web service call is creating a new record in the ad_session table. This is used to calculate if the maximum number of web service calls has been reached for the current instance.

This calculation is not needed in an instance with unlimited web service calls, so those ad_session records are unnecessary data which in environments that make intensive use of the web services are taking up a lot of space in the database.
Steps To ReproduceIn description
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0030031 closedalostale row created in ad_session for same cookie after every erp logout 
related to feature request 0032880 closedinigosanchez Instance Activation window should displayed information about WS calls, CU and active POS terminals. 
related to defect 0036141 closedalostale stateful WS calls create HttpSessions that live till Tomcat kills them 
related to defect 00363643.0PR17Q3 closedmtaal Http Sessions are registered in SessionListener with wrong session id, stateless requests should not be registered 
related to defect 0040813 closedcaristu A NPE can be thrown when using the default web service authentication of the AuthenticationManager 
causes defect 0040897 closedalostale unreachable system after tying to create a record through ws with unlimited access license 

-  Notes
(0096647)
hgbot (developer)
2017-05-17 16:07

 Repository: erp/mods/org.openbravo.platform.features
Changeset: 796d12e92fd69916f9aa03a4dff87df96ff43853
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed May 17 16:07:04 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.platform.features/rev/796d12e92fd69916f9aa03a4dff87df96ff43853 [^]

related to issue 35994: added stateless web service for testing purposes

---
A config/org.openbravo.platform.features-provider-config.xml
A src/org/openbravo/platform/features/service/BusinessPartnerCurrencyWebService.java
---
(0096655)
hgbot (developer)
2017-05-18 09:06

 Repository: erp/devel/pi
Changeset: 383058dac5699aa263e209cbfcd10000b8153d3f
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu May 18 09:00:59 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/383058dac5699aa263e209cbfcd10000b8153d3f [^]

fixes bug 35994: WS should not create ad_session records having unlimited calls

When the authentication through the webServiceAuthenticate method is done, now if the request comes from a web service and the current license has unlimited web service calls then no record is created in the AD_Session because this record is just needed when the system calculates if the maximum number of web service calls has been reached.

---
M src/org/openbravo/authentication/AuthenticationManager.java
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/service/web/BaseWebServiceServlet.java
---
(0096659)
hgbot (developer)
2017-05-18 12:32

 Repository: erp/devel/pi
Changeset: 0eb140120f4edb1dc63ad491d6ea69fb3e6fd3e2
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu May 18 12:30:55 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0eb140120f4edb1dc63ad491d6ea69fb3e6fd3e2 [^]

related to bug 35994: hide number of ws calls if the instance is unlimited

Do not show the number of ws calls performed throughout the day in the "Instance Activation" window if the current instance has unlimited number of ws calls.

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0096974)
hudsonbot (developer)
2017-05-29 17:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0096975)
hudsonbot (developer)
2017-05-29 17:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test
(0097008)
alostale (manager)
2017-05-30 12:42
edited on: 2017-05-31 10:45

 reopening due to code review:

-No need to set in request this is a WS call, as webServicePostAuthenticate is only called for WS
-don't get list of expired modules for every single WS call
-HttpSession is not created for steateful WS
(0097017)
hgbot (developer)
2017-05-30 16:05

 Repository: erp/devel/pi
Changeset: a85be898ff3b3e51a53c2907c96305c426865497
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue May 30 16:00:32 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a85be898ff3b3e51a53c2907c96305c426865497 [^]

related to issue 35994: code review improvements
- No need to set in request this is a WS call, as webServicePostAuthenticate is only called for WS.
- Do not get list of expired modules for every single WS call.

---
M src/org/openbravo/authentication/AuthenticationManager.java
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/service/web/BaseWebServiceServlet.java
---
(0097020)
hgbot (developer)
2017-05-30 17:01

 Repository: erp/devel/api-checks
Changeset: dc9f6f461f2bc0f30581bcf7fc0943b8296ce56d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue May 30 17:00:55 2017 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/dc9f6f461f2bc0f30581bcf7fc0943b8296ce56d [^]

related to issue 35994: removed unneeded WS_CALL field from API

---
M java/reference/java.japi.gz
---
(0097023)
hgbot (developer)
2017-05-30 17:19

 Repository: erp/devel/pi
Changeset: 0f858c02b0dd7ba077306cae051ffa9c5bdc05df
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue May 30 17:18:23 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0f858c02b0dd7ba077306cae051ffa9c5bdc05df [^]

related to issue 35994: create http session in stateful WS requests

It was missing to create the http session for the stateful WS requests being in an environment with unlimited WS access

---
M src/org/openbravo/authentication/AuthenticationManager.java
---
(0097046)
alostale (manager)
2017-05-31 11:02

 code reviewed

Tested with limited and unlimited WS restriction and stateless and stateful WS calls. Working in all cases as expected AD_Session/HttpSession is created when it is supposed to.
(0097051)
hudsonbot (developer)
2017-05-31 15:23

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e39fb42d847c [^]
Maturity status: Test
(0097052)
hudsonbot (developer)
2017-05-31 15:23

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e39fb42d847c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-05-15 11:36 caristu New Issue
2017-05-15 11:36 caristu Assigned To => platform
2017-05-15 11:36 caristu Modules => Core
2017-05-15 11:36 caristu Triggers an Emergency Pack => No
2017-05-15 11:36 caristu Assigned To platform => caristu
2017-05-15 11:36 caristu Status new => scheduled
2017-05-15 11:41 caristu Tag Attached: Performance
2017-05-15 12:51 caristu File Added: issue35994.diff
2017-05-17 08:49 caristu Relationship added related to 0030031
2017-05-17 09:18 caristu File Deleted: issue35994.diff
2017-05-17 16:07 hgbot Checkin
2017-05-17 16:07 hgbot Note Added: 0096647
2017-05-18 09:06 hgbot Checkin
2017-05-18 09:06 hgbot Note Added: 0096655
2017-05-18 09:06 hgbot Status scheduled => resolved
2017-05-18 09:06 hgbot Resolution open => fixed
2017-05-18 09:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/383058dac5699aa263e209cbfcd10000b8153d3f [^]
2017-05-18 09:07 caristu Review Assigned To => alostale
2017-05-18 09:17 caristu Relationship added related to 0032880
2017-05-18 12:32 hgbot Checkin
2017-05-18 12:32 hgbot Note Added: 0096659
2017-05-18 16:43 shuehner Issue Monitored: shuehner
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096974
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096975
2017-05-30 12:42 alostale Note Added: 0097008
2017-05-30 12:42 alostale Status resolved => new
2017-05-30 12:42 alostale Resolution fixed => open
2017-05-30 16:05 hgbot Checkin
2017-05-30 16:05 hgbot Note Added: 0097017
2017-05-30 16:07 caristu Status new => scheduled
2017-05-30 16:07 caristu Status scheduled => resolved
2017-05-30 16:07 caristu Resolution open => fixed
2017-05-30 17:01 hgbot Checkin
2017-05-30 17:01 hgbot Note Added: 0097020
2017-05-30 17:05 alostale Relationship added related to 0036141
2017-05-30 17:19 hgbot Checkin
2017-05-30 17:19 hgbot Note Added: 0097023
2017-05-31 10:45 alostale Note Edited: 0097008 View Revisions
2017-05-31 11:02 alostale Note Added: 0097046
2017-05-31 11:02 alostale Status resolved => closed
2017-05-31 11:02 alostale Fixed in Version => 3.0PR17Q3
2017-05-31 15:23 hudsonbot Checkin
2017-05-31 15:23 hudsonbot Note Added: 0097051
2017-05-31 15:23 hudsonbot Checkin
2017-05-31 15:23 hudsonbot Note Added: 0097052
2017-07-03 10:11 alostale Relationship added related to 0036364
2019-05-08 17:02 caristu Relationship added related to 0040813
2019-05-17 11:02 alostale Relationship added causes 0040897

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker