Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035935
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSmajorhave not tried2017-05-06 08:422017-11-07 12:51
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revision80bb76c015fd
ProjectionnoneETAnoneTarget VersionRR17Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035935: Performance reading cashup: set maxresults as only one record is used

DescriptionThe code here [1] only uses one record/object returned from the query. Therefore it makes sense to set maxresults to 1

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/3c405052fa16/src/org/openbravo/retail/posterminal/master/Cashup.java#l89 [^]
Steps To ReproduceSee code
Proposed SolutionsetMaxResults(1) on the query
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0037245RR18Q1 closedrqueralta Missing index in master.Cashup causes query to be slow 

-  Notes
(0096432)
hgbot (developer)
2017-05-06 08:51

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 80bb76c015fd441b3376bc151190926a5bfcf8c0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat May 06 08:51:36 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/80bb76c015fd441b3376bc151190926a5bfcf8c0 [^]

Fixes issue 35935: Performance reading cashup: set maxresults as only one record is used
Set maxResults(1)

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
---
(0100304)
ALopetegui (reporter)
2017-11-07 12:49

 Reopened only to schedule backport
(0100305)
ALopetegui (reporter)
2017-11-07 12:51

 Closing again, was just reopened to schedule backport.

- Issue History
Date Modified Username Field Change
2017-05-06 08:42 mtaal New Issue
2017-05-06 08:42 mtaal Assigned To => mtaal
2017-05-06 08:42 mtaal Triggers an Emergency Pack => No
2017-05-06 08:43 mtaal Review Assigned To => marvintm
2017-05-06 08:51 hgbot Checkin
2017-05-06 08:51 hgbot Note Added: 0096432
2017-05-06 08:51 hgbot Status new => resolved
2017-05-06 08:51 hgbot Resolution open => fixed
2017-05-06 08:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/80bb76c015fd441b3376bc151190926a5bfcf8c0 [^]
2017-05-09 11:03 marvintm Status resolved => closed
2017-05-09 11:03 marvintm Fixed in Version => RR17Q3
2017-11-07 11:54 shuehner Tag Attached: Performance
2017-11-07 12:49 ALopetegui Status closed => new
2017-11-07 12:49 ALopetegui Resolution fixed => open
2017-11-07 12:49 ALopetegui Fixed in Version RR17Q3 =>
2017-11-07 12:49 ALopetegui Status new => scheduled
2017-11-07 12:49 ALopetegui Note Added: 0100304
2017-11-07 12:51 ALopetegui Status scheduled => resolved
2017-11-07 12:51 ALopetegui Fixed in Version => RR17Q3
2017-11-07 12:51 ALopetegui Resolution open => fixed
2017-11-07 12:51 ALopetegui Note Added: 0100305
2017-11-07 12:51 ALopetegui Status resolved => closed
2017-11-07 13:02 ALopetegui Relationship added related to 0037245

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker