Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035935Retail ModulesWeb POSpublic2017-05-06 08:422017-11-07 12:51
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q3Fixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035935: Performance reading cashup: set maxresults as only one record is used
DescriptionThe code here [1] only uses one record/object returned from the query. Therefore it makes sense to set maxresults to 1

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/3c405052fa16/src/org/openbravo/retail/posterminal/master/Cashup.java#l89 [^]
Steps To ReproduceSee code
Proposed SolutionsetMaxResults(1) on the query
Additional Information
TagsPerformance
Relationships
related to defect 0037245RR18Q1 closed rqueralta Missing index in master.Cashup causes query to be slow 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-06 08:42mtaalNew Issue
2017-05-06 08:42mtaalAssigned To => mtaal
2017-05-06 08:42mtaalOBNetwork customer => No
2017-05-06 08:42mtaalTriggers an Emergency Pack => No
2017-05-06 08:43mtaalReview Assigned To => marvintm
2017-05-06 08:51hgbotCheckin
2017-05-06 08:51hgbotNote Added: 0096432
2017-05-06 08:51hgbotStatusnew => resolved
2017-05-06 08:51hgbotResolutionopen => fixed
2017-05-06 08:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/80bb76c015fd441b3376bc151190926a5bfcf8c0 [^]
2017-05-09 11:03marvintmStatusresolved => closed
2017-05-09 11:03marvintmFixed in Version => RR17Q3
2017-11-07 11:54shuehnerTag Attached: Performance
2017-11-07 12:49ALopeteguiStatusclosed => new
2017-11-07 12:49ALopeteguiResolutionfixed => open
2017-11-07 12:49ALopeteguiFixed in VersionRR17Q3 =>
2017-11-07 12:49ALopeteguiStatusnew => scheduled
2017-11-07 12:49ALopeteguiNote Added: 0100304
2017-11-07 12:51ALopeteguiStatusscheduled => resolved
2017-11-07 12:51ALopeteguiFixed in Version => RR17Q3
2017-11-07 12:51ALopeteguiResolutionopen => fixed
2017-11-07 12:51ALopeteguiNote Added: 0100305
2017-11-07 12:51ALopeteguiStatusresolved => closed
2017-11-07 13:02ALopeteguiRelationship addedrelated to 0037245

Notes
(0096432)
hgbot   
2017-05-06 08:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 80bb76c015fd441b3376bc151190926a5bfcf8c0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat May 06 08:51:36 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/80bb76c015fd441b3376bc151190926a5bfcf8c0 [^]

Fixes issue 35935: Performance reading cashup: set maxresults as only one record is used
Set maxResults(1)

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
---
(0100304)
ALopetegui   
2017-11-07 12:49   
Reopened only to schedule backport
(0100305)
ALopetegui   
2017-11-07 12:51   
Closing again, was just reopened to schedule backport.