Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035902
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-05-03 07:312017-05-17 19:14
ReporterguillermogilView Statuspublic 
Assigned Tojorge-garcia 
PriorityhighResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revisionea7eefc48b7b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035902: Duplicated cashups are not handled properly in obpos_errors and c_import_entry

DescriptionRight now if we try to send again from WebPOS a cashup that has been previously processed no one will now it as the cashup is not on Errors While Importing window because it is consider as a duplicated.
This should be no error but it is executing the importEntryPostProcessor which can rely on some error with third parties if there is some process listening to that hook.
Steps To ReproduceLogin to the same terminal on WebPOS from 2 different computers or two different browser sessions. e.g.- one with chrome user A and one in incognito mode

Ensure that both WebSQL have the same cashup id.

Do two tickets and a cashup in one on them.
Ensure that it has been synched properly.

Close that browser to avoid a human error.

Go to the other browser session.

Do a ticket and a cashup.

Go to the backend.

Go to Errors while importing window.
You will see the new created order but not the cashup.

Also, cashup import entry has called to the importEntryPostProcessor which can rely on some error with third parties.
Proposed SolutionIn this case the cashup record should go to obpos_errors as it is a case that needs a review.
With that we can have the same behavior for cashups and orders.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0096407)
hgbot (developer)
2017-05-05 08:28

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ea7eefc48b7b4c05aefa82004fe0caf09c44f3f1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu May 04 09:48:16 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea7eefc48b7b4c05aefa82004fe0caf09c44f3f1 [^]

Fixed issue 35902: Duplicated cashups are not handled properly in
obpos_errors and c_import_entry

If the cashup is set as processed and processeddbo to true, the new record
throws an exection and is send to the obpos_errors table.

---
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---

- Issue History
Date Modified Username Field Change
2017-05-03 07:31 guillermogil New Issue
2017-05-03 07:31 guillermogil Assigned To => Retail
2017-05-03 07:31 guillermogil OBNetwork customer => Yes
2017-05-03 07:31 guillermogil Resolution time => 1495576800
2017-05-03 07:31 guillermogil Triggers an Emergency Pack => No
2017-05-03 16:48 jorge-garcia Assigned To Retail => jorge-garcia
2017-05-03 16:48 jorge-garcia Status new => acknowledged
2017-05-04 09:46 jorge-garcia Status acknowledged => scheduled
2017-05-05 08:28 hgbot Checkin
2017-05-05 08:28 hgbot Note Added: 0096407
2017-05-05 08:28 hgbot Status scheduled => resolved
2017-05-05 08:28 hgbot Resolution open => fixed
2017-05-05 08:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea7eefc48b7b4c05aefa82004fe0caf09c44f3f1 [^]
2017-05-17 19:14 marvintm Review Assigned To => marvintm
2017-05-17 19:14 marvintm Status resolved => closed
2017-05-17 19:14 marvintm Fixed in Version => RR17Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker