Openbravo Issue Tracking System - Retail Modules
View Issue Details
0035902Retail ModulesWeb POSpublic2017-05-03 07:312017-05-17 19:14
guillermogil 
jorge-garcia 
highmajoralways
closedfixed 
5
 
RR17Q3 
marvintm
No
0035902: Duplicated cashups are not handled properly in obpos_errors and c_import_entry
Right now if we try to send again from WebPOS a cashup that has been previously processed no one will now it as the cashup is not on Errors While Importing window because it is consider as a duplicated.
This should be no error but it is executing the importEntryPostProcessor which can rely on some error with third parties if there is some process listening to that hook.
Login to the same terminal on WebPOS from 2 different computers or two different browser sessions. e.g.- one with chrome user A and one in incognito mode

Ensure that both WebSQL have the same cashup id.

Do two tickets and a cashup in one on them.
Ensure that it has been synched properly.

Close that browser to avoid a human error.

Go to the other browser session.

Do a ticket and a cashup.

Go to the backend.

Go to Errors while importing window.
You will see the new created order but not the cashup.

Also, cashup import entry has called to the importEntryPostProcessor which can rely on some error with third parties.
In this case the cashup record should go to obpos_errors as it is a case that needs a review.
With that we can have the same behavior for cashups and orders.
No tags attached.
Issue History
2017-05-03 07:31guillermogilNew Issue
2017-05-03 07:31guillermogilAssigned To => Retail
2017-05-03 07:31guillermogilResolution time => 1495576800
2017-05-03 07:31guillermogilTriggers an Emergency Pack => No
2017-05-03 16:48jorge-garciaAssigned ToRetail => jorge-garcia
2017-05-03 16:48jorge-garciaStatusnew => acknowledged
2017-05-04 09:46jorge-garciaStatusacknowledged => scheduled
2017-05-05 08:28hgbotCheckin
2017-05-05 08:28hgbotNote Added: 0096407
2017-05-05 08:28hgbotStatusscheduled => resolved
2017-05-05 08:28hgbotResolutionopen => fixed
2017-05-05 08:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea7eefc48b7b4c05aefa82004fe0caf09c44f3f1 [^]
2017-05-17 19:14marvintmReview Assigned To => marvintm
2017-05-17 19:14marvintmStatusresolved => closed
2017-05-17 19:14marvintmFixed in Version => RR17Q3

Notes
(0096407)
hgbot   
2017-05-05 08:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ea7eefc48b7b4c05aefa82004fe0caf09c44f3f1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu May 04 09:48:16 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea7eefc48b7b4c05aefa82004fe0caf09c44f3f1 [^]

Fixed issue 35902: Duplicated cashups are not handled properly in
obpos_errors and c_import_entry

If the cashup is set as processed and processeddbo to true, the new record
throws an exection and is send to the obpos_errors table.

---
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---