Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035860 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Gift cards and gift vouchers | major | have not tried | 2017-04-27 13:36 | 2017-05-15 14:45 | |||
| Reporter | plujan | View Status | public | |||||
| Assigned To | jorge-garcia | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 01f0ee985020 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | main | SCM revision | ||||||
| Review Assigned To | migueldejuana | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035860: [RR17Q2] Saving a Gif Card with a non-exempt Tax Category does not raise an error message | |||||||
| Description | When creating a new Product of Gift Card type, the most common mistake is to try to save using the default values, "Stocked" marked and "IVA Normal" Tax Category. An error is shown when "Stocked" is marked, but it is possible to save the record using the wrong tax category. Later in the webPOS, an error is shown when the gift card is used. | |||||||
| Steps To Reproduce | 1. Create a Gift Card in the Backend's Product window, letting the Stocked check marked and the "IVA Normal" category set (as they come by default) 2. Complete the rest of the header mandatory fields and save. 3. [Expected behaviour] An error is shown "Saving failed. The gift card products must be marked as tax exempt and non stocked." 4. Unmark the "Stocked" check and save. 5. [Wrong behaviour] The record can be saved. (See attached screenshot) 6. Try to add the product to the webPOS, an error is shown (See attached screenshot) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  GiftCardError17q2.png [^] (126,399 bytes) 2017-04-27 13:36
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0096537) hgbot (developer) 2017-05-11 17:41 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: 01f0ee98502018e94995b6414b8282274f00afe9 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Thu May 11 17:41:05 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/01f0ee98502018e94995b6414b8282274f00afe9 [^] Fixed issue 35860: [RR17Q2] Saving a Gif Card with a non-exempt Tax Category does not raise an error message The problem only affects to gift card type product. The problem here is, at the time the user tries to save the gift card record with a specific tax category, the event handler can not know if finally, the tax category that will be applied to the gift will be a tax exempt. For this reason, all checks are done in the client side, at the specific moment the gift card is set to the ticket. Finally, checks done in the ERP and WebPOS are correct as they are right now. So, the only change required is to change is the error message show if the gift card is tried to save as a stocked product. --- M src-db/database/sourcedata/AD_MESSAGE.xml --- |
|
(0096597) migueldejuana (developer) 2017-05-15 14:45 |
Reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-04-27 13:36 | plujan | New Issue | |
| 2017-04-27 13:36 | plujan | Assigned To | => Retail |
| 2017-04-27 13:36 | plujan | File Added: GiftCardError17q2.png | |
| 2017-04-27 13:36 | plujan | Triggers an Emergency Pack | => No |
| 2017-04-27 14:21 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2017-04-27 14:21 | ranjith_qualiantech_com | Status | new => scheduled |
| 2017-05-11 17:35 | jorge-garcia | Assigned To | ranjith_qualiantech_com => jorge-garcia |
| 2017-05-11 17:41 | hgbot | Checkin | |
| 2017-05-11 17:41 | hgbot | Note Added: 0096537 | |
| 2017-05-11 17:41 | hgbot | Status | scheduled => resolved |
| 2017-05-11 17:41 | hgbot | Resolution | open => fixed |
| 2017-05-11 17:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/01f0ee98502018e94995b6414b8282274f00afe9 [^] |
| 2017-05-15 14:45 | migueldejuana | Review Assigned To | => migueldejuana |
| 2017-05-15 14:45 | migueldejuana | Note Added: 0096597 | |
| 2017-05-15 14:45 | migueldejuana | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |