Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035860Retail ModulesGift cards and gift voucherspublic2017-04-27 13:362017-05-15 14:45
Reporterplujan 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035860: [RR17Q2] Saving a Gif Card with a non-exempt Tax Category does not raise an error message
DescriptionWhen creating a new Product of Gift Card type, the most common mistake is to try to save using the default values, "Stocked" marked and "IVA Normal" Tax Category.
An error is shown when "Stocked" is marked, but it is possible to save the record using the wrong tax category.

Later in the webPOS, an error is shown when the gift card is used.
Steps To Reproduce1. Create a Gift Card in the Backend's Product window, letting the Stocked check marked and the "IVA Normal" category set (as they come by default)
2. Complete the rest of the header mandatory fields and save.
3. [Expected behaviour] An error is shown "Saving failed. The gift card products must be marked as tax exempt and non stocked."
4. Unmark the "Stocked" check and save.
5. [Wrong behaviour] The record can be saved. (See attached screenshot)
6. Try to add the product to the webPOS, an error is shown (See attached screenshot)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng GiftCardError17q2.png (126,399) 2017-04-27 13:36
https://issues.openbravo.com/file_download.php?file_id=10695&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-04-27 13:36plujanNew Issue
2017-04-27 13:36plujanAssigned To => Retail
2017-04-27 13:36plujanFile Added: GiftCardError17q2.png
2017-04-27 13:36plujanTriggers an Emergency Pack => No
2017-04-27 14:21ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-04-27 14:21ranjith_qualiantech_comStatusnew => scheduled
2017-05-11 17:35jorge-garciaAssigned Toranjith_qualiantech_com => jorge-garcia
2017-05-11 17:41hgbotCheckin
2017-05-11 17:41hgbotNote Added: 0096537
2017-05-11 17:41hgbotStatusscheduled => resolved
2017-05-11 17:41hgbotResolutionopen => fixed
2017-05-11 17:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/01f0ee98502018e94995b6414b8282274f00afe9 [^]
2017-05-15 14:45migueldejuanaReview Assigned To => migueldejuana
2017-05-15 14:45migueldejuanaNote Added: 0096597
2017-05-15 14:45migueldejuanaStatusresolved => closed

Notes
(0096537)
hgbot   
2017-05-11 17:41   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 01f0ee98502018e94995b6414b8282274f00afe9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu May 11 17:41:05 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/01f0ee98502018e94995b6414b8282274f00afe9 [^]

Fixed issue 35860: [RR17Q2] Saving a Gif Card with a non-exempt Tax Category
does not raise an error message

The problem only affects to gift card type product.

The problem here is, at the time the user tries to save the gift card record with
a specific tax category, the event handler can not know if finally, the tax
category that will be applied to the gift will be a tax exempt.

For this reason, all checks are done in the client side, at the specific moment
the gift card is set to the ticket.

Finally, checks done in the ERP and WebPOS are correct as they are right now.

So, the only change required is to change is the error message show if the gift
card is tried to save as a stocked product.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0096597)
migueldejuana   
2017-05-15 14:45   
Reviewed