Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035858
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-04-27 13:262017-05-08 09:29
ReporterjorgewederagoView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revisione063519daf9d
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035858: When applying more than 2 discounts to the same line the information about them is generated wrongly.

DescriptionIf you apply more than 2 discounts to the same line and finish the transaction, if you go to the ERP and check the information related to them you will see that the values are not correctly generated so the information stored in the database is not correct.
Steps To Reproduce1.- In the ERP go to discounts and promotions and generate (for eg) 4 Discretionary Fixed Amount discounts.
2.- In WebPOS buy something and apply all the discounts to it.
3.- Finish the transaction
4.- Go to the ERP to the Sales order window, select the order and line and check the values in Base Gross Unit Price displayed in discounts and promotions.
Proposed SolutionThe following code seems wrong since it applies twice the discounts due accumulators.

base = line.get('price');
        _.forEach(line.get('promotions') || [], function (discount) {
          var discountAmt = discount.actualAmt || discount.amt || 0;
          discount.basePrice = base;
          discount.unitDiscount = OB.DEC.div(discountAmt, line.get('qtyToApplyDisc') || line.get('qty'));
          totalDiscount = OB.DEC.add(totalDiscount, discountAmt);
          base = OB.DEC.sub(base, totalDiscount);
        }, this);
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0035861RR17Q2.1 closedjorge-garcia When applying more than 2 discounts to the same line the information about them is generated wrongly. 
depends on backport 0035862RR17Q1.2 closedjorge-garcia When applying more than 2 discounts to the same line the information about them is generated wrongly. 

-  Notes
(0096306)
hgbot (developer)
2017-05-02 13:01

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e063519daf9d714912cd76fd82e1f54da0e6d798
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Apr 28 14:15:13 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e063519daf9d714912cd76fd82e1f54da0e6d798 [^]

Fixed issue 35858: When applying more than 2 discounts to the same line the
information about them is generated wrongly.

The solution is to used the discounted amount per product instead of the
discount accumulated to calculate the base price in each promotion.o

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0096307)
hgbot (developer)
2017-05-02 13:02

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 6d9d35117c6f80976ca8cdbb39068affc9d99450
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Apr 28 14:14:40 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/6d9d35117c6f80976ca8cdbb39068affc9d99450 [^]

Related issue 35858: When applying more than 2 discounts to the same line the
information about them is generated wrongly.

Create some new manual discounts to test the functionality.

Those new discounts are by default inactive and are activated by the test.

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0096308)
hgbot (developer)
2017-05-02 13:03

 Repository: tools/automation/pi-mobile
Changeset: 6e3656dcf7428ed627ec21743982c78a3f30bd07
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 02 10:27:54 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6e3656dcf7428ed627ec21743982c78a3f30bd07 [^]

Verifies issue 35858: When applying more than 2 discounts to the same line the
information about them is generated wrongly.

Added test I35858_CorrectDataInBackendWithSeveralManualPromotions.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35858_CorrectDataInBackendWithSeveralManualPromotions.java
---

- Issue History
Date Modified Username Field Change
2017-04-27 13:26 jorgewederago New Issue
2017-04-27 13:26 jorgewederago Assigned To => Retail
2017-04-27 13:26 jorgewederago OBNetwork customer => Yes
2017-04-27 13:26 jorgewederago Resolution time => 1491170400
2017-04-27 13:26 jorgewederago Triggers an Emergency Pack => No
2017-04-27 13:26 jorgewederago Resolution time 1491170400 => 1493762400
2017-04-27 13:42 marvintm Severity critical => major
2017-04-27 13:45 marvintm Status new => scheduled
2017-04-27 13:45 marvintm Assigned To Retail => jorge-garcia
2017-05-02 13:01 hgbot Checkin
2017-05-02 13:01 hgbot Note Added: 0096306
2017-05-02 13:01 hgbot Status scheduled => resolved
2017-05-02 13:01 hgbot Resolution open => fixed
2017-05-02 13:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e063519daf9d714912cd76fd82e1f54da0e6d798 [^]
2017-05-02 13:02 hgbot Checkin
2017-05-02 13:02 hgbot Note Added: 0096307
2017-05-02 13:03 hgbot Checkin
2017-05-02 13:03 hgbot Note Added: 0096308
2017-05-08 09:29 marvintm Review Assigned To => marvintm
2017-05-08 09:29 marvintm Status resolved => closed
2017-05-08 09:29 marvintm Fixed in Version => RR17Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker