Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035768 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] StoreServer | minor | have not tried | 2017-04-12 12:26 | 2017-05-22 13:07 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR17Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 4a7e85b6e999 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | AugustoMauch | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035768: Review calls to MobileServerController.getThisServerDefinition | |||||||
| Description | The MobileServerController.getThisServerDefinition executes a query to get the updated mobile server definition of the current server. There are many callers of this method that don't need an updated version, that only need to know if it is null, or the value of some properties that do not change. For instance, [1] only checks the mobile server client, [2] only checks if it is null, [3] only checks the mobile server id and its server type, etc. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/c0b32b2cd2e2/src/org/openbravo/mobile/core/listener/StatusBackgroundProcessScheduler.java#l44 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/c0b32b2cd2e2/src/org/openbravo/mobile/core/servercontroller/MobileServerController.java#l116 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/c0b32b2cd2e2/src/org/openbravo/mobile/core/servercontroller/MobileServerController.java#l73 [^] | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Store a cached object of the mobile server definition. Create a method that returns this cached server, that should be called by those caller that don't need to have access to the mobile server fields that change (i.e. status) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0096434) hgbot (developer) 2017-05-06 09:13 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 4a7e85b6e9991bf50a6e5a7046642dc737312fd3 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat May 06 09:11:33 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a7e85b6e9991bf50a6e5a7046642dc737312fd3 [^] Fixes issue 35768: Review calls to MobileServerController.getThisServerDefinition Added some convenience methods to the MobileServereController: getMobileServerKey, getServerClientId and made use of these methods in various locations in the code. --- M src/org/openbravo/mobile/core/listener/StatusBackgroundProcessScheduler.java M src/org/openbravo/mobile/core/servercontroller/ForceTransitionToOnline.java M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java M src/org/openbravo/mobile/core/servercontroller/MobileServerJSONProcess.java M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java M src/org/openbravo/mobile/core/servercontroller/MobileServerStatusInformation.java M src/org/openbravo/mobile/core/servercontroller/RetrieveMobileServerStatus.java --- |
|
(0096709) hgbot (developer) 2017-05-22 13:06 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 2115e49f67fd955857fa129b57aac38343ccbc0f Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon May 22 13:06:25 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2115e49f67fd955857fa129b57aac38343ccbc0f [^] Related with issue 35768: Fixes Java format --- M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java --- |
|
(0096710) AugustoMauch (administrator) 2017-05-22 13:07 |
Code reviewed and verified |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-04-12 12:26 | AugustoMauch | New Issue | |
| 2017-04-12 12:26 | AugustoMauch | Assigned To | => StoreServer |
| 2017-04-12 12:26 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2017-04-12 12:26 | AugustoMauch | Relationship added | related to 0035754 |
| 2017-05-01 17:19 | mtaal | Assigned To | StoreServer => mtaal |
| 2017-05-06 09:13 | hgbot | Checkin | |
| 2017-05-06 09:13 | hgbot | Note Added: 0096434 | |
| 2017-05-06 09:13 | hgbot | Status | new => resolved |
| 2017-05-06 09:13 | hgbot | Resolution | open => fixed |
| 2017-05-06 09:13 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a7e85b6e9991bf50a6e5a7046642dc737312fd3 [^] |
| 2017-05-07 21:30 | mtaal | Review Assigned To | => AugustoMauch |
| 2017-05-22 13:06 | hgbot | Checkin | |
| 2017-05-22 13:06 | hgbot | Note Added: 0096709 | |
| 2017-05-22 13:07 | AugustoMauch | Note Added: 0096710 | |
| 2017-05-22 13:07 | AugustoMauch | Status | resolved => closed |
| 2017-05-22 13:07 | AugustoMauch | Fixed in Version | => RR17Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |