Openbravo Issue Tracking System - Retail Modules | ||||||||||||
| View Issue Details | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |||||||
| 0035768 | Retail Modules | StoreServer | public | 2017-04-12 12:26 | 2017-05-22 13:07 | |||||||
| Reporter | AugustoMauch | |||||||||||
| Assigned To | mtaal | |||||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | |||||||
| Status | closed | Resolution | fixed | |||||||||
| Platform | OS | 5 | OS Version | |||||||||
| Product Version | ||||||||||||
| Target Version | Fixed in Version | RR17Q3 | ||||||||||
| Merge Request Status | ||||||||||||
| Review Assigned To | AugustoMauch | |||||||||||
| OBNetwork customer | ||||||||||||
| Support ticket | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0035768: Review calls to MobileServerController.getThisServerDefinition | |||||||||||
| Description | The MobileServerController.getThisServerDefinition executes a query to get the updated mobile server definition of the current server. There are many callers of this method that don't need an updated version, that only need to know if it is null, or the value of some properties that do not change. For instance, [1] only checks the mobile server client, [2] only checks if it is null, [3] only checks the mobile server id and its server type, etc. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/c0b32b2cd2e2/src/org/openbravo/mobile/core/listener/StatusBackgroundProcessScheduler.java#l44 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/c0b32b2cd2e2/src/org/openbravo/mobile/core/servercontroller/MobileServerController.java#l116 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/c0b32b2cd2e2/src/org/openbravo/mobile/core/servercontroller/MobileServerController.java#l73 [^] | |||||||||||
| Steps To Reproduce | - | |||||||||||
| Proposed Solution | Store a cached object of the mobile server definition. Create a method that returns this cached server, that should be called by those caller that don't need to have access to the mobile server fields that change (i.e. status) | |||||||||||
| Additional Information | ||||||||||||
| Tags | No tags attached. | |||||||||||
| Relationships |
| |||||||||||
| Attached Files | ||||||||||||
| Issue History | ||||||||||||
| Date Modified | Username | Field | Change | |||||||||
| 2017-04-12 12:26 | AugustoMauch | New Issue | ||||||||||
| 2017-04-12 12:26 | AugustoMauch | Assigned To | => StoreServer | |||||||||
| 2017-04-12 12:26 | AugustoMauch | Triggers an Emergency Pack | => No | |||||||||
| 2017-04-12 12:26 | AugustoMauch | Relationship added | related to 0035754 | |||||||||
| 2017-05-01 17:19 | mtaal | Assigned To | StoreServer => mtaal | |||||||||
| 2017-05-06 09:13 | hgbot | Checkin | ||||||||||
| 2017-05-06 09:13 | hgbot | Note Added: 0096434 | ||||||||||
| 2017-05-06 09:13 | hgbot | Status | new => resolved | |||||||||
| 2017-05-06 09:13 | hgbot | Resolution | open => fixed | |||||||||
| 2017-05-06 09:13 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a7e85b6e9991bf50a6e5a7046642dc737312fd3 [^] | |||||||||
| 2017-05-07 21:30 | mtaal | Review Assigned To | => AugustoMauch | |||||||||
| 2017-05-22 13:06 | hgbot | Checkin | ||||||||||
| 2017-05-22 13:06 | hgbot | Note Added: 0096709 | ||||||||||
| 2017-05-22 13:07 | AugustoMauch | Note Added: 0096710 | ||||||||||
| 2017-05-22 13:07 | AugustoMauch | Status | resolved => closed | |||||||||
| 2017-05-22 13:07 | AugustoMauch | Fixed in Version | => RR17Q3 | |||||||||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||