Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035667 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [Retail Modules] StoreServer | minor | have not tried | 2017-03-31 12:29 | 2017-04-10 06:12 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR17Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | mtaal | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035667: Move duplicate code together in one method in MultiServerJSONProcess | |||||||
| Description | The code that handlers the flow when there is an exception here [1] and here [2] is duplicated. It would be better if this code is extracted to a function. Also, this line [3] states that the transition to offline will only be done if the node is not transitioning. But the transition to offline should be done if the node is transitioning to online, right? [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/012e6b7ab09c/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l361 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/012e6b7ab09c/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l418 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/012e6b7ab09c/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l432 [^] | |||||||
| Steps To Reproduce | See Descroption | |||||||
| Proposed Solution | See Description | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0095925) mtaal (viewer) 2017-04-10 06:12 |
Resolved in this commit: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0769bc9065a6f0825bc776b8a94915f59775b34c#l1.130 [^] |
|
(0095926) mtaal (viewer) 2017-04-10 06:12 |
Code change will be reviewed in issue in which the commit happened |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-03-31 12:29 | mtaal | New Issue | |
| 2017-03-31 12:29 | mtaal | Assigned To | => mtaal |
| 2017-03-31 12:29 | mtaal | OBNetwork customer | => No |
| 2017-03-31 12:29 | mtaal | Triggers an Emergency Pack | => No |
| 2017-03-31 12:29 | mtaal | Relationship added | related to 0035601 |
| 2017-04-10 06:11 | mtaal | Status | new => scheduled |
| 2017-04-10 06:12 | mtaal | Note Added: 0095925 | |
| 2017-04-10 06:12 | mtaal | Status | scheduled => resolved |
| 2017-04-10 06:12 | mtaal | Resolution | open => fixed |
| 2017-04-10 06:12 | mtaal | Review Assigned To | => mtaal |
| 2017-04-10 06:12 | mtaal | Note Added: 0095926 | |
| 2017-04-10 06:12 | mtaal | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |