Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035667Retail ModulesStoreServerpublic2017-03-31 12:292017-04-10 06:12
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q3Fixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035667: Move duplicate code together in one method in MultiServerJSONProcess
DescriptionThe code that handlers the flow when there is an exception here [1] and here [2] is duplicated. It would be better if this code is extracted to a function.

Also, this line [3] states that the transition to offline will only be done if the node is not transitioning. But the transition to offline should be done if the node is transitioning to online, right?

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/012e6b7ab09c/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l361 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/012e6b7ab09c/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l418 [^]
[3] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/012e6b7ab09c/src/org/openbravo/mobile/core/servercontroller/MultiServerJSONProcess.java#l432 [^]

Steps To ReproduceSee Descroption
Proposed SolutionSee Description
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035601RR17Q2 closed mtaal Transition to offline is not triggered at every location in the MultiServerJSONProcess code 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-31 12:29mtaalNew Issue
2017-03-31 12:29mtaalAssigned To => mtaal
2017-03-31 12:29mtaalTriggers an Emergency Pack => No
2017-03-31 12:29mtaalRelationship addedrelated to 0035601
2017-04-10 06:11mtaalStatusnew => scheduled
2017-04-10 06:12mtaalNote Added: 0095925
2017-04-10 06:12mtaalStatusscheduled => resolved
2017-04-10 06:12mtaalResolutionopen => fixed
2017-04-10 06:12mtaalReview Assigned To => mtaal
2017-04-10 06:12mtaalNote Added: 0095926
2017-04-10 06:12mtaalStatusresolved => closed

Notes
(0095925)
mtaal   
2017-04-10 06:12   
Resolved in this commit:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0769bc9065a6f0825bc776b8a94915f59775b34c#l1.130 [^]
(0095926)
mtaal   
2017-04-10 06:12   
Code change will be reviewed in issue in which the commit happened