Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0035623 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2017-03-27 14:39 | 2017-05-16 10:28 | |||
Reporter | adrianromero | View Status | public | |||||
Assigned To | mario_castello | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR17Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | f7be27b20bea | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | marvintm | |||||||
OBNetwork customer | OBPS | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0035623: [SER-QA 2673] In a paid ticket, when trying to add a new payment, providers are executed before rejecting the payment | |||||||
Description | In a paid ticket, if the user tries to add a new payment, payment providers code are executed before rejecting the payment. This is very important because if for example the payment provider is an electronic payment then the electronic payment is executed BEFORE rejecting the payment. So the payment has been charged to the user but rejected and never added to the receipt. | |||||||
Steps To Reproduce | * In ERP in the payment methods tab for Terminal Types a payment set Payment provider to "Confirm payment dialog" a dummy payment provider that just shows a dialog before adding de payment. * In Web POS load a paid ticket * Go to the payments dialog and try to add a new payment: * Observe the confirm payment dialog of the provider configured appears. | |||||||
Proposed Solution | Add the check to reject the payments before invoking payment providers. See changeset attached | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|
![]() |
|
(0095837) hgbot (developer) 2017-04-04 21:02 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f7be27b20beaf11a149f2125d98c65a5fb3efdef Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Apr 04 10:03:01 2017 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f7be27b20beaf11a149f2125d98c65a5fb3efdef [^] Fixed issue 0035623: [SER-QA 2673] In a paid ticket, when trying to add a new payment, providers are executed before rejecting the payment - Added validation before executed the payment provider --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js --- |
(0095869) hgbot (developer) 2017-04-06 16:38 |
Repository: tools/automation/pi-mobile Changeset: 1b88368faca8f53468eff7697ce4eba2df1d54ee Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Wed Apr 05 15:42:34 2017 -0600 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1b88368faca8f53468eff7697ce4eba2df1d54ee [^] Verifies issue 35623: Added automated test 'I35623_OpenReceiptAndPaymentProvider' - Added new tesIds in the TestIdPack class --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35623_OpenReceiptAndPaymentProvider.java --- |
(0096615) hgbot (developer) 2017-05-16 10:28 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: cd13ce1880cacd17a67146e9961babdbc91309e7 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon May 15 17:59:08 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cd13ce1880cacd17a67146e9961babdbc91309e7 [^] Related issue 35830, related issue 35623 It is breaking I35623_OpenReceiptAndPaymentProvider Backed out changeset abe131fd8ece --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
![]() |
|||
Date Modified | Username | Field | Change |
2017-03-27 14:39 | adrianromero | New Issue | |
2017-03-27 14:39 | adrianromero | Assigned To | => Retail |
2017-03-27 14:39 | adrianromero | OBNetwork customer | => Yes |
2017-03-27 14:39 | adrianromero | Resolution time | => 1491775200 |
2017-03-27 14:39 | adrianromero | Triggers an Emergency Pack | => No |
2017-03-27 14:47 | adrianromero | File Added: issue35623.diff | |
2017-03-27 22:53 | mario_castello | Assigned To | Retail => mario_castello |
2017-03-27 23:21 | mario_castello | Status | new => acknowledged |
2017-04-04 17:57 | mario_castello | Status | acknowledged => scheduled |
2017-04-04 21:02 | hgbot | Checkin | |
2017-04-04 21:02 | hgbot | Note Added: 0095837 | |
2017-04-04 21:02 | hgbot | Status | scheduled => resolved |
2017-04-04 21:02 | hgbot | Resolution | open => fixed |
2017-04-04 21:02 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f7be27b20beaf11a149f2125d98c65a5fb3efdef [^] |
2017-04-06 16:38 | hgbot | Checkin | |
2017-04-06 16:38 | hgbot | Note Added: 0095869 | |
2017-04-07 12:03 | marvintm | Review Assigned To | => marvintm |
2017-04-07 12:03 | marvintm | Status | resolved => closed |
2017-04-07 12:03 | marvintm | Fixed in Version | => RR17Q3 |
2017-05-16 10:28 | hgbot | Checkin | |
2017-05-16 10:28 | hgbot | Note Added: 0096615 |
Copyright © 2000 - 2009 MantisBT Group |