0035623: [SER-QA 2673] In a paid ticket, when trying to add a new payment, providers are executed before rejecting the payment

Openbravo Issue Tracking System - Retail Modules
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0035623	Retail Modules	Web POS	public	2017-03-27 14:39	2017-05-16 10:28

Reporter	adrianromero
Assigned To	mario_castello
Priority	urgent	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version	RR17Q3
Merge Request Status
Review Assigned To	marvintm
OBNetwork customer	OBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0035623: [SER-QA 2673] In a paid ticket, when trying to add a new payment, providers are executed before rejecting the payment
Description	In a paid ticket, if the user tries to add a new payment, payment providers code are executed before rejecting the payment. This is very important because if for example the payment provider is an electronic payment then the electronic payment is executed BEFORE rejecting the payment. So the payment has been charged to the user but rejected and never added to the receipt.
Steps To Reproduce	* In ERP in the payment methods tab for Terminal Types a payment set Payment provider to "Confirm payment dialog" a dummy payment provider that just shows a dialog before adding de payment. * In Web POS load a paid ticket * Go to the payments dialog and try to add a new payment: * Observe the confirm payment dialog of the provider configured appears.
Proposed Solution	Add the check to reject the payments before invoking payment providers. See changeset attached
Additional Information
Tags	No tags attached.
Relationships
Attached Files	issue35623.diff (1,340) 2017-03-27 14:47 https://issues.openbravo.com/file_download.php?file_id=10608&type=bug

Issue History
Date Modified	Username	Field	Change
2017-03-27 14:39	adrianromero	New Issue
2017-03-27 14:39	adrianromero	Assigned To	=> Retail
2017-03-27 14:39	adrianromero	OBNetwork customer	=> Yes
2017-03-27 14:39	adrianromero	Resolution time	=> 1491775200
2017-03-27 14:39	adrianromero	Triggers an Emergency Pack	=> No
2017-03-27 14:47	adrianromero	File Added: issue35623.diff
2017-03-27 22:53	mario_castello	Assigned To	Retail => mario_castello
2017-03-27 23:21	mario_castello	Status	new => acknowledged
2017-04-04 17:57	mario_castello	Status	acknowledged => scheduled
2017-04-04 21:02	hgbot	Checkin
2017-04-04 21:02	hgbot	Note Added: 0095837
2017-04-04 21:02	hgbot	Status	scheduled => resolved
2017-04-04 21:02	hgbot	Resolution	open => fixed
2017-04-04 21:02	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f7be27b20beaf11a149f2125d98c65a5fb3efdef [^]
2017-04-06 16:38	hgbot	Checkin
2017-04-06 16:38	hgbot	Note Added: 0095869
2017-04-07 12:03	marvintm	Review Assigned To	=> marvintm
2017-04-07 12:03	marvintm	Status	resolved => closed
2017-04-07 12:03	marvintm	Fixed in Version	=> RR17Q3
2017-05-16 10:28	hgbot	Checkin
2017-05-16 10:28	hgbot	Note Added: 0096615

Notes