Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035618 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2017-03-27 10:33 | 2017-03-29 17:56 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR17Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ec32db46bde9 | ||||
| Projection | none | ETA | none | Target Version | RR17Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035618: Specific flow in mobileservice will result in the servlet service method to be called twice | |||||||
| Description | See the flow in mobile service [1]. The logic in the if-then-else block continues after the call the super.service, resulting in the other call to super.service [2] to be also executed. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/77ecce7f71b5/src/org/openbravo/mobile/core/process/MobileService.java#l84 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/77ecce7f71b5/src/org/openbravo/mobile/core/process/MobileService.java#l106 [^] | |||||||
| Steps To Reproduce | . | |||||||
| Proposed Solution | Add a return statement after the calls to super.service in the if-then-else block. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0095630) hgbot (developer) 2017-03-29 09:53 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: ec32db46bde931331f2c1a3a22a4968a8997c2dd Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Mar 29 09:52:33 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ec32db46bde931331f2c1a3a22a4968a8997c2dd [^] Fixes issue 35618, related to issue 35495: Keep track if a store server needs to sync with central before allowing connections Add return to prevent double execution of super.service Move the allow request handler to the getpost method so that the super class can correctly handle generic logic such as cors requests --- M src/org/openbravo/mobile/core/process/MobileService.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-03-27 10:33 | mtaal | New Issue | |
| 2017-03-27 10:33 | mtaal | Assigned To | => mtaal |
| 2017-03-27 10:33 | mtaal | Triggers an Emergency Pack | => No |
| 2017-03-29 09:53 | hgbot | Checkin | |
| 2017-03-29 09:53 | hgbot | Note Added: 0095630 | |
| 2017-03-29 09:53 | hgbot | Status | new => resolved |
| 2017-03-29 09:53 | hgbot | Resolution | open => fixed |
| 2017-03-29 09:53 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ec32db46bde931331f2c1a3a22a4968a8997c2dd [^] |
| 2017-03-29 09:56 | mtaal | Review Assigned To | => marvintm |
| 2017-03-29 17:56 | marvintm | Status | resolved => closed |
| 2017-03-29 17:56 | marvintm | Fixed in Version | => RR17Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |