Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035618Retail ModulesWeb POSpublic2017-03-27 10:332017-03-29 17:56
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035618: Specific flow in mobileservice will result in the servlet service method to be called twice
DescriptionSee the flow in mobile service [1]. The logic in the if-then-else block continues after the call the super.service, resulting in the other call to super.service [2] to be also executed.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/77ecce7f71b5/src/org/openbravo/mobile/core/process/MobileService.java#l84 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/77ecce7f71b5/src/org/openbravo/mobile/core/process/MobileService.java#l106 [^]
Steps To Reproduce.
Proposed SolutionAdd a return statement after the calls to super.service in the if-then-else block.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-27 10:33mtaalNew Issue
2017-03-27 10:33mtaalAssigned To => mtaal
2017-03-27 10:33mtaalOBNetwork customer => No
2017-03-27 10:33mtaalTriggers an Emergency Pack => No
2017-03-29 09:53hgbotCheckin
2017-03-29 09:53hgbotNote Added: 0095630
2017-03-29 09:53hgbotStatusnew => resolved
2017-03-29 09:53hgbotResolutionopen => fixed
2017-03-29 09:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ec32db46bde931331f2c1a3a22a4968a8997c2dd [^]
2017-03-29 09:56mtaalReview Assigned To => marvintm
2017-03-29 17:56marvintmStatusresolved => closed
2017-03-29 17:56marvintmFixed in Version => RR17Q2

Notes
(0095630)
hgbot   
2017-03-29 09:53   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ec32db46bde931331f2c1a3a22a4968a8997c2dd
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Mar 29 09:52:33 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ec32db46bde931331f2c1a3a22a4968a8997c2dd [^]

Fixes issue 35618, related to issue 35495: Keep track if a store server needs to sync with central before allowing connections

Add return to prevent double execution of super.service
Move the allow request handler to the getpost method so that the super class can correctly handle generic logic such as
cors requests

---
M src/org/openbravo/mobile/core/process/MobileService.java
---