Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0035593 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] StoreServer | minor | have not tried | 2017-03-22 11:22 | 2017-03-30 16:05 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 552fb04e6ce9 | ||||
Projection | none | ETA | none | Target Version | RR17Q2 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | AugustoMauch | |||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0035593: MobileServerRequestExecutor.handleOtherServerStatus should also use CheckServerOfflineHandler | |||||||
Description | MobileServerRequestExecutor.handleOtherServerStatus [1] checks in store servers if its central server is online, in that case it triggers the transition to online. It does not check CheckServerOfflineHandler. It should do/use this code also. Possibly check if code can be re-used. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/553553b86771/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java#l375 [^] | |||||||
Steps To Reproduce | See Description | |||||||
Proposed Solution | See Description | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0095649) hgbot (developer) 2017-03-29 14:28 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 552fb04e6ce97325299a790739849bce8902c226 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Mar 29 14:28:08 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/552fb04e6ce97325299a790739849bce8902c226 [^] Fixes issue 35593: MobileServerRequestExecutor.handleOtherServerStatus should also use CheckServerOfflineHandler Use the same common method to transition to online, ensuring that the same logic is used everywhere --- M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java --- |
(0095719) AugustoMauch (administrator) 2017-03-30 16:05 |
Code reviewed and verified |
![]() |
|||
Date Modified | Username | Field | Change |
2017-03-22 11:22 | mtaal | New Issue | |
2017-03-22 11:22 | mtaal | Assigned To | => mtaal |
2017-03-22 11:22 | mtaal | OBNetwork customer | => No |
2017-03-22 11:22 | mtaal | Triggers an Emergency Pack | => No |
2017-03-29 14:28 | mtaal | Review Assigned To | => AugustoMauch |
2017-03-29 14:28 | hgbot | Checkin | |
2017-03-29 14:28 | hgbot | Note Added: 0095649 | |
2017-03-29 14:28 | hgbot | Status | new => resolved |
2017-03-29 14:28 | hgbot | Resolution | open => fixed |
2017-03-29 14:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/552fb04e6ce97325299a790739849bce8902c226 [^] |
2017-03-30 16:05 | AugustoMauch | Note Added: 0095719 | |
2017-03-30 16:05 | AugustoMauch | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |