Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035593Retail ModulesStoreServerpublic2017-03-22 11:222017-03-30 16:05
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035593: MobileServerRequestExecutor.handleOtherServerStatus should also use CheckServerOfflineHandler
DescriptionMobileServerRequestExecutor.handleOtherServerStatus [1] checks in store servers if its central server is online, in that case it triggers the transition to online. It does not check CheckServerOfflineHandler.

It should do/use this code also. Possibly check if code can be re-used.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/553553b86771/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java#l375 [^]
Steps To ReproduceSee Description
Proposed SolutionSee Description
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-22 11:22mtaalNew Issue
2017-03-22 11:22mtaalAssigned To => mtaal
2017-03-22 11:22mtaalTriggers an Emergency Pack => No
2017-03-29 14:28mtaalReview Assigned To => AugustoMauch
2017-03-29 14:28hgbotCheckin
2017-03-29 14:28hgbotNote Added: 0095649
2017-03-29 14:28hgbotStatusnew => resolved
2017-03-29 14:28hgbotResolutionopen => fixed
2017-03-29 14:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/552fb04e6ce97325299a790739849bce8902c226 [^]
2017-03-30 16:05AugustoMauchNote Added: 0095719
2017-03-30 16:05AugustoMauchStatusresolved => closed

Notes
(0095649)
hgbot   
2017-03-29 14:28   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 552fb04e6ce97325299a790739849bce8902c226
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Mar 29 14:28:08 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/552fb04e6ce97325299a790739849bce8902c226 [^]

Fixes issue 35593: MobileServerRequestExecutor.handleOtherServerStatus should also use CheckServerOfflineHandler
Use the same common method to transition to online, ensuring that the same logic is used everywhere

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0095719)
AugustoMauch   
2017-03-30 16:05   
Code reviewed and verified