Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035583
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts Combomajoralways2017-03-21 14:262017-03-30 18:27
ReportermalsasuaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR17Q2
StatusclosedFix in branchFixed in SCM revision18506abbe32b
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket45997
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035583: wrong amount applying combo discount

DescriptionIn some cases, the combo discount is applying a incorrect discount amount.
Steps To Reproducesee attachment
TagsNo tags attached.
Attached Filesdocx file icon Combowithhigherprice.docx [^] (572,157 bytes) 2017-03-21 14:26

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0037178 closedmalsasua When combo is added and total button is clicked, the lines of ticket are removed and total amount is set to 0 
related to design defect 0037350 newRetail Discounts should be applied event if it generates a bigger price 

-  Notes
(0095603)
hgbot (developer)
2017-03-28 14:52

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 082789e8220f6d58b46ce606c2332512725d0123
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 28 18:21:53 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/082789e8220f6d58b46ce606c2332512725d0123 [^]

Fixes issue 35583 : Changes in Combo Fix Price Calculation

* If Line Price should be lesser than Combo Fix price, then combo discount should not be added for that line

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0095616)
hgbot (developer)
2017-03-29 07:49

 Repository: tools/automation/pi-mobile
Changeset: 68b32bda7620712c32dedda89e57b9f442d885e7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 29 11:19:10 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/68b32bda7620712c32dedda89e57b9f442d885e7 [^]

Verifies issue 35583 : Added automated test 'I35583_VerifyComboFixPrice'

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I35583_VerifyComboFixPrice.java
---
(0095632)
marvintm (viewer)
2017-03-29 10:02

 Fix is not taking into account the case of Fixed price combos, only fixed price for particular families.
(0095645)
hgbot (developer)
2017-03-29 14:16

 Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: c939f45030c060872ed2d4f6361af801838d5666
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 29 17:45:52 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/c939f45030c060872ed2d4f6361af801838d5666 [^]

Related to issue 35583 : Changes in Combo Fix Price Calculation

* If Discount Type is "Combo Fix Price" and Combo Lines Total Amount is lesser than Combo Fix price, then combo discount should not be applied

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0095697)
hgbot (developer)
2017-03-30 11:35

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 18506abbe32b892d46e52427e5c0bebc25c55696
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 30 15:05:01 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/18506abbe32b892d46e52427e5c0bebc25c55696 [^]

Fixes issue 35583 : Changes in Discount Pack Calculation

* If Discount Type is "Pack" and Pack Lines Total Amount is lesser than Pack Amount, then pack discount should not be applied

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0095699)
hgbot (developer)
2017-03-30 11:36

 Repository: tools/automation/pi-mobile
Changeset: 00e81e0b329760951d589cf80c0a6015829e6c02
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 30 15:05:23 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/00e81e0b329760951d589cf80c0a6015829e6c02 [^]

Verifies issue 35583 : Added automated test 'I35583_VerifyPackAmountWithLineAmount'

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I35583_VerifyComboFixPriceII.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I35583_VerifyPackAmountWithLineAmount.java
---

- Issue History
Date Modified Username Field Change
2017-03-21 14:26 malsasua New Issue
2017-03-21 14:26 malsasua Assigned To => Retail
2017-03-21 14:26 malsasua File Added: Combowithhigherprice.docx
2017-03-21 14:26 malsasua OBNetwork customer => Yes
2017-03-21 14:26 malsasua Support ticket => 45997
2017-03-21 14:26 malsasua Resolution time => 1490652000
2017-03-21 14:26 malsasua Triggers an Emergency Pack => No
2017-03-21 14:38 malsasua Severity critical => major
2017-03-21 14:51 jpcalvente Issue Monitored: jpcalvente
2017-03-21 16:03 malsasua Resolution time 1490652000 => 1492120800
2017-03-28 13:20 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2017-03-28 13:21 ranjith_qualiantech_com Status new => scheduled
2017-03-28 14:52 hgbot Checkin
2017-03-28 14:52 hgbot Note Added: 0095603
2017-03-28 14:52 hgbot Status scheduled => resolved
2017-03-28 14:52 hgbot Resolution open => fixed
2017-03-28 14:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/082789e8220f6d58b46ce606c2332512725d0123 [^]
2017-03-29 07:49 hgbot Checkin
2017-03-29 07:49 hgbot Note Added: 0095616
2017-03-29 10:02 marvintm Note Added: 0095632
2017-03-29 10:02 marvintm Status resolved => new
2017-03-29 10:02 marvintm Resolution fixed => open
2017-03-29 14:16 hgbot Checkin
2017-03-29 14:16 hgbot Note Added: 0095645
2017-03-29 14:21 ranjith_qualiantech_com Status new => scheduled
2017-03-29 16:05 marvintm Status scheduled => resolved
2017-03-29 16:05 marvintm Resolution open => fixed
2017-03-29 17:18 marvintm Status resolved => new
2017-03-29 17:18 marvintm Resolution fixed => open
2017-03-29 17:18 marvintm Status new => scheduled
2017-03-30 11:35 hgbot Checkin
2017-03-30 11:35 hgbot Note Added: 0095697
2017-03-30 11:35 hgbot Status scheduled => resolved
2017-03-30 11:35 hgbot Resolution open => fixed
2017-03-30 11:35 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/082789e8220f6d58b46ce606c2332512725d0123 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/18506abbe32b892d46e52427e5c0bebc25c55696 [^]
2017-03-30 11:36 hgbot Checkin
2017-03-30 11:36 hgbot Note Added: 0095699
2017-03-30 18:27 marvintm Review Assigned To => marvintm
2017-03-30 18:27 marvintm Status resolved => closed
2017-03-30 18:27 marvintm Fixed in Version => RR17Q2
2017-11-13 13:37 jorge-garcia Relationship added related to 0037178
2017-11-22 08:35 guillermogil Relationship added related to 0037350

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker