Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035583Retail ModulesDiscounts Combopublic2017-03-21 14:262017-03-30 18:27
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket45997
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035583: wrong amount applying combo discount
DescriptionIn some cases, the combo discount is applying a incorrect discount amount.
Steps To Reproducesee attachment
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037178 closed malsasua When combo is added and total button is clicked, the lines of ticket are removed and total amount is set to 0 
related to design defect 0037350 new Retail Discounts should be applied event if it generates a bigger price 
Attached Filesdocx Combowithhigherprice.docx (572,157) 2017-03-21 14:26
https://issues.openbravo.com/file_download.php?file_id=10588&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-21 14:26malsasuaNew Issue
2017-03-21 14:26malsasuaAssigned To => Retail
2017-03-21 14:26malsasuaFile Added: Combowithhigherprice.docx
2017-03-21 14:26malsasuaOBNetwork customer => Yes
2017-03-21 14:26malsasuaSupport ticket => 45997
2017-03-21 14:26malsasuaResolution time => 1490652000
2017-03-21 14:26malsasuaTriggers an Emergency Pack => No
2017-03-21 14:38malsasuaSeveritycritical => major
2017-03-21 14:51jpcalventeIssue Monitored: jpcalvente
2017-03-21 16:03malsasuaResolution time1490652000 => 1492120800
2017-03-28 13:20ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-03-28 13:21ranjith_qualiantech_comStatusnew => scheduled
2017-03-28 14:52hgbotCheckin
2017-03-28 14:52hgbotNote Added: 0095603
2017-03-28 14:52hgbotStatusscheduled => resolved
2017-03-28 14:52hgbotResolutionopen => fixed
2017-03-28 14:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/082789e8220f6d58b46ce606c2332512725d0123 [^]
2017-03-29 07:49hgbotCheckin
2017-03-29 07:49hgbotNote Added: 0095616
2017-03-29 10:02marvintmNote Added: 0095632
2017-03-29 10:02marvintmStatusresolved => new
2017-03-29 10:02marvintmResolutionfixed => open
2017-03-29 14:16hgbotCheckin
2017-03-29 14:16hgbotNote Added: 0095645
2017-03-29 14:21ranjith_qualiantech_comStatusnew => scheduled
2017-03-29 16:05marvintmStatusscheduled => resolved
2017-03-29 16:05marvintmResolutionopen => fixed
2017-03-29 17:18marvintmStatusresolved => new
2017-03-29 17:18marvintmResolutionfixed => open
2017-03-29 17:18marvintmStatusnew => scheduled
2017-03-30 11:35hgbotCheckin
2017-03-30 11:35hgbotNote Added: 0095697
2017-03-30 11:35hgbotStatusscheduled => resolved
2017-03-30 11:35hgbotResolutionopen => fixed
2017-03-30 11:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/082789e8220f6d58b46ce606c2332512725d0123 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/18506abbe32b892d46e52427e5c0bebc25c55696 [^]
2017-03-30 11:36hgbotCheckin
2017-03-30 11:36hgbotNote Added: 0095699
2017-03-30 18:27marvintmReview Assigned To => marvintm
2017-03-30 18:27marvintmStatusresolved => closed
2017-03-30 18:27marvintmFixed in Version => RR17Q2
2017-11-13 13:37jorge-garciaRelationship addedrelated to 0037178
2017-11-22 08:35guillermogilRelationship addedrelated to 0037350

Notes
(0095603)
hgbot   
2017-03-28 14:52   
Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 082789e8220f6d58b46ce606c2332512725d0123
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 28 18:21:53 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/082789e8220f6d58b46ce606c2332512725d0123 [^]

Fixes issue 35583 : Changes in Combo Fix Price Calculation

* If Line Price should be lesser than Combo Fix price, then combo discount should not be added for that line

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0095616)
hgbot   
2017-03-29 07:49   
Repository: tools/automation/pi-mobile
Changeset: 68b32bda7620712c32dedda89e57b9f442d885e7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 29 11:19:10 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/68b32bda7620712c32dedda89e57b9f442d885e7 [^]

Verifies issue 35583 : Added automated test 'I35583_VerifyComboFixPrice'

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I35583_VerifyComboFixPrice.java
---
(0095632)
marvintm   
2017-03-29 10:02   
Fix is not taking into account the case of Fixed price combos, only fixed price for particular families.
(0095645)
hgbot   
2017-03-29 14:16   
Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: c939f45030c060872ed2d4f6361af801838d5666
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 29 17:45:52 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/c939f45030c060872ed2d4f6361af801838d5666 [^]

Related to issue 35583 : Changes in Combo Fix Price Calculation

* If Discount Type is "Combo Fix Price" and Combo Lines Total Amount is lesser than Combo Fix price, then combo discount should not be applied

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0095697)
hgbot   
2017-03-30 11:35   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 18506abbe32b892d46e52427e5c0bebc25c55696
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 30 15:05:01 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/18506abbe32b892d46e52427e5c0bebc25c55696 [^]

Fixes issue 35583 : Changes in Discount Pack Calculation

* If Discount Type is "Pack" and Pack Lines Total Amount is lesser than Pack Amount, then pack discount should not be applied

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0095699)
hgbot   
2017-03-30 11:36   
Repository: tools/automation/pi-mobile
Changeset: 00e81e0b329760951d589cf80c0a6015829e6c02
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Mar 30 15:05:23 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/00e81e0b329760951d589cf80c0a6015829e6c02 [^]

Verifies issue 35583 : Added automated test 'I35583_VerifyPackAmountWithLineAmount'

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I35583_VerifyComboFixPriceII.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I35583_VerifyPackAmountWithLineAmount.java
---