Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035565
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Cash Managementmajoralways2017-03-17 22:342017-04-07 16:24
ReporterrbianchiniView Statuspublic 
Assigned Tomario_castello 
PriorityimmediateResolutionfixedFixed in VersionRR17Q2
StatusclosedFix in branchFixed in SCM revisioncae84f51b1ae
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionRR17Q1SCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket45456
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035565: Wrong transaction type in POS transaction

Descriptionwhen do cash up, the amount that gets transferred from the Individual accounts to the master accounts is deposited as a Transaction Type - "BP Withdrawal" instead of "BP Deposit". This error is reporducible from 15Q2. In 14Q3.5 , this works fine.
Steps To Reproduce1-Enter the Web POS Environment
2-Make an order, pay it and do the Cah Up
3-Enter the back office
4-Go to Financial Account "Cashbook - Vall Blanca Backoffice", tab Transaction
5-See that the type of the transaction generated is BP Withdrawal and should be BP Deposit
TagsNo tags attached.
Attached Filesdiff file icon fixIssue35565_16Q4.2.diff [^] (1,379 bytes) 2017-04-06 18:49 [Show Content]
txt file icon script.txt [^] (239 bytes) 2017-04-07 16:24 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0095568)
hgbot (developer)
2017-03-24 16:25

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e2fac497b725f51b7909466b727451912a980218
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Mar 20 13:56:58 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2fac497b725f51b7909466b727451912a980218 [^]

Fixed issue 0035565: Wrong transaction type in POS transaction

- Changes the transaction type to deposit when the transaction is a deposit in master acount

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---
(0095569)
hgbot (developer)
2017-03-24 16:27

 Repository: tools/automation/pi-mobile
Changeset: 6b9b4428ea8e72f0bdd6b90ae91f688d5d1240e5
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Mar 22 13:40:41 2017 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6b9b4428ea8e72f0bdd6b90ae91f688d5d1240e5 [^]

Verifies issue 35565: Fixed automated test affected by the last change

---
M src-test/org/openbravo/test/mobile/retail/pack/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/MultiterminalSaleAndCashupVerifyingDatabase.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/SaleAndCashupVerifyingDatabaseII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par1Fin2.java
---
(0095570)
hgbot (developer)
2017-03-24 16:28

 Repository: tools/automation/pi-mobile
Changeset: a8a8dfef9bcdf74c1f47dc00d1fe1a8f0006f9c2
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Mar 23 10:05:11 2017 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a8a8dfef9bcdf74c1f47dc00d1fe1a8f0006f9c2 [^]

Verifies issue 35565: Fixed test SPMMulticurrencyPayInEURUSD

---
M src-test/org/openbravo/test/mobile/retail/pack/database/WebPOSDatabaseHelper.java
---
(0095571)
mario_castello (viewer)
2017-03-24 16:31

 Related to issue 35565: Added automated test I35565_CashUpVerifyDeposit

https://code.openbravo.com/tools/automation/pi-mobile/rev/25f51da108d2 [^]
(0095612)
marvintm (viewer)
2017-03-28 17:20

 Fix is correct, but there is another case of the same problem in this same file, when creating the differences transaction, which also needs to be fixed.
(0095679)
hgbot (developer)
2017-03-29 21:23

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cae84f51b1aec6034d4875bbfdb5a455cf04f311
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Mar 28 10:06:14 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cae84f51b1aec6034d4875bbfdb5a455cf04f311 [^]

Fixed issue 0035565: Wrong transaction type in POS transaction

- Set the correct transaction type based on the value of transaction.
- 'BPD' for deposit transaction and 'BPW' for withdrawal transaction.

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---
(0095680)
hgbot (developer)
2017-03-29 21:25

 Repository: tools/automation/pi-mobile
Changeset: f257d1016c40ab07d23dcd6e353a0511020b198a
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Mar 29 10:45:11 2017 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f257d1016c40ab07d23dcd6e353a0511020b198a [^]

Verifies issue 35565: Fixed automated test affected by the last change

- Fixed test MultiterminalSaleAndCashupVerifyingDatabase
- Fixed test Layaway_Cre1Par1Fin2
- Fixed validation in WebPOSDatabaseHelper class

---
M src-test/org/openbravo/test/mobile/retail/pack/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/MultiterminalSaleAndCashupVerifyingDatabase.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par1Fin2.java
---

- Issue History
Date Modified Username Field Change
2017-03-17 22:34 rbianchini New Issue
2017-03-17 22:34 rbianchini Assigned To => Retail
2017-03-17 22:34 rbianchini OBNetwork customer => Yes
2017-03-17 22:34 rbianchini Support ticket => 45456
2017-03-17 22:34 rbianchini Resolution time => 1491447600
2017-03-17 22:34 rbianchini Regression level => Production - Confirmed Stable
2017-03-17 22:34 rbianchini Triggers an Emergency Pack => No
2017-03-20 16:08 mario_castello Assigned To Retail => mario_castello
2017-03-20 21:01 mario_castello Status new => acknowledged
2017-03-20 21:01 mario_castello Status acknowledged => scheduled
2017-03-24 16:25 hgbot Checkin
2017-03-24 16:25 hgbot Note Added: 0095568
2017-03-24 16:25 hgbot Status scheduled => resolved
2017-03-24 16:25 hgbot Resolution open => fixed
2017-03-24 16:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2fac497b725f51b7909466b727451912a980218 [^]
2017-03-24 16:27 hgbot Checkin
2017-03-24 16:27 hgbot Note Added: 0095569
2017-03-24 16:28 hgbot Checkin
2017-03-24 16:28 hgbot Note Added: 0095570
2017-03-24 16:31 mario_castello Note Added: 0095571
2017-03-28 17:20 marvintm Note Added: 0095612
2017-03-28 17:20 marvintm Status resolved => new
2017-03-28 17:20 marvintm Resolution fixed => open
2017-03-28 18:08 mario_castello Status new => scheduled
2017-03-29 21:23 hgbot Checkin
2017-03-29 21:23 hgbot Note Added: 0095679
2017-03-29 21:23 hgbot Status scheduled => resolved
2017-03-29 21:23 hgbot Resolution open => fixed
2017-03-29 21:23 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2fac497b725f51b7909466b727451912a980218 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cae84f51b1aec6034d4875bbfdb5a455cf04f311 [^]
2017-03-29 21:25 hgbot Checkin
2017-03-29 21:25 hgbot Note Added: 0095680
2017-03-30 10:05 marvintm Review Assigned To => marvintm
2017-03-30 10:05 marvintm Status resolved => closed
2017-03-30 10:05 marvintm Fixed in Version => RR17Q2
2017-04-06 18:49 mario_castello File Added: fixIssue35565_16Q4.2.diff
2017-04-06 19:44 mario_castello File Added: script.txt
2017-04-07 16:23 mario_castello File Deleted: script.txt
2017-04-07 16:24 mario_castello File Added: script.txt

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker