Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035565Retail ModulesCash Managementpublic2017-03-17 22:342017-04-07 16:24
Reporterrbianchini 
Assigned Tomario_castello 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR17Q1 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035565: Wrong transaction type in POS transaction
Descriptionwhen do cash up, the amount that gets transferred from the Individual accounts to the master accounts is deposited as a Transaction Type - "BP Withdrawal" instead of "BP Deposit". This error is reporducible from 15Q2. In 14Q3.5 , this works fine.
Steps To Reproduce1-Enter the Web POS Environment
2-Make an order, pay it and do the Cah Up
3-Enter the back office
4-Go to Financial Account "Cashbook - Vall Blanca Backoffice", tab Transaction
5-See that the type of the transaction generated is BP Withdrawal and should be BP Deposit
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff fixIssue35565_16Q4.2.diff (1,379) 2017-04-06 18:49
https://issues.openbravo.com/file_download.php?file_id=10651&type=bug
txt script.txt (239) 2017-04-07 16:24
https://issues.openbravo.com/file_download.php?file_id=10662&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-17 22:34rbianchiniNew Issue
2017-03-17 22:34rbianchiniAssigned To => Retail
2017-03-17 22:34rbianchiniResolution time => 1491447600
2017-03-17 22:34rbianchiniRegression level => Production - Confirmed Stable
2017-03-17 22:34rbianchiniTriggers an Emergency Pack => No
2017-03-20 16:08mario_castelloAssigned ToRetail => mario_castello
2017-03-20 21:01mario_castelloStatusnew => acknowledged
2017-03-20 21:01mario_castelloStatusacknowledged => scheduled
2017-03-24 16:25hgbotCheckin
2017-03-24 16:25hgbotNote Added: 0095568
2017-03-24 16:25hgbotStatusscheduled => resolved
2017-03-24 16:25hgbotResolutionopen => fixed
2017-03-24 16:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2fac497b725f51b7909466b727451912a980218 [^]
2017-03-24 16:27hgbotCheckin
2017-03-24 16:27hgbotNote Added: 0095569
2017-03-24 16:28hgbotCheckin
2017-03-24 16:28hgbotNote Added: 0095570
2017-03-24 16:31mario_castelloNote Added: 0095571
2017-03-28 17:20marvintmNote Added: 0095612
2017-03-28 17:20marvintmStatusresolved => new
2017-03-28 17:20marvintmResolutionfixed => open
2017-03-28 18:08mario_castelloStatusnew => scheduled
2017-03-29 21:23hgbotCheckin
2017-03-29 21:23hgbotNote Added: 0095679
2017-03-29 21:23hgbotStatusscheduled => resolved
2017-03-29 21:23hgbotResolutionopen => fixed
2017-03-29 21:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2fac497b725f51b7909466b727451912a980218 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cae84f51b1aec6034d4875bbfdb5a455cf04f311 [^]
2017-03-29 21:25hgbotCheckin
2017-03-29 21:25hgbotNote Added: 0095680
2017-03-30 10:05marvintmReview Assigned To => marvintm
2017-03-30 10:05marvintmStatusresolved => closed
2017-03-30 10:05marvintmFixed in Version => RR17Q2
2017-04-06 18:49mario_castelloFile Added: fixIssue35565_16Q4.2.diff
2017-04-06 19:44mario_castelloFile Added: script.txt
2017-04-07 16:23mario_castelloFile Deleted: script.txt
2017-04-07 16:24mario_castelloFile Added: script.txt

Notes
(0095568)
hgbot   
2017-03-24 16:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e2fac497b725f51b7909466b727451912a980218
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Mar 20 13:56:58 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2fac497b725f51b7909466b727451912a980218 [^]

Fixed issue 0035565: Wrong transaction type in POS transaction

- Changes the transaction type to deposit when the transaction is a deposit in master acount

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---
(0095569)
hgbot   
2017-03-24 16:27   
Repository: tools/automation/pi-mobile
Changeset: 6b9b4428ea8e72f0bdd6b90ae91f688d5d1240e5
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Mar 22 13:40:41 2017 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6b9b4428ea8e72f0bdd6b90ae91f688d5d1240e5 [^]

Verifies issue 35565: Fixed automated test affected by the last change

---
M src-test/org/openbravo/test/mobile/retail/pack/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/MultiterminalSaleAndCashupVerifyingDatabase.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/SaleAndCashupVerifyingDatabaseII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par1Fin2.java
---
(0095570)
hgbot   
2017-03-24 16:28   
Repository: tools/automation/pi-mobile
Changeset: a8a8dfef9bcdf74c1f47dc00d1fe1a8f0006f9c2
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Mar 23 10:05:11 2017 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a8a8dfef9bcdf74c1f47dc00d1fe1a8f0006f9c2 [^]

Verifies issue 35565: Fixed test SPMMulticurrencyPayInEURUSD

---
M src-test/org/openbravo/test/mobile/retail/pack/database/WebPOSDatabaseHelper.java
---
(0095571)
mario_castello   
2017-03-24 16:31   
Related to issue 35565: Added automated test I35565_CashUpVerifyDeposit

https://code.openbravo.com/tools/automation/pi-mobile/rev/25f51da108d2 [^]
(0095612)
marvintm   
2017-03-28 17:20   
Fix is correct, but there is another case of the same problem in this same file, when creating the differences transaction, which also needs to be fixed.
(0095679)
hgbot   
2017-03-29 21:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cae84f51b1aec6034d4875bbfdb5a455cf04f311
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Mar 28 10:06:14 2017 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cae84f51b1aec6034d4875bbfdb5a455cf04f311 [^]

Fixed issue 0035565: Wrong transaction type in POS transaction

- Set the correct transaction type based on the value of transaction.
- 'BPD' for deposit transaction and 'BPW' for withdrawal transaction.

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---
(0095680)
hgbot   
2017-03-29 21:25   
Repository: tools/automation/pi-mobile
Changeset: f257d1016c40ab07d23dcd6e353a0511020b198a
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Mar 29 10:45:11 2017 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f257d1016c40ab07d23dcd6e353a0511020b198a [^]

Verifies issue 35565: Fixed automated test affected by the last change

- Fixed test MultiterminalSaleAndCashupVerifyingDatabase
- Fixed test Layaway_Cre1Par1Fin2
- Fixed validation in WebPOSDatabaseHelper class

---
M src-test/org/openbravo/test/mobile/retail/pack/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/MultiterminalSaleAndCashupVerifyingDatabase.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/Layaway_Cre1Par1Fin2.java
---