Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0035557 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
design defect | [Retail Modules] StoreServer | minor | have not tried | 2017-03-17 12:00 | 2017-03-21 10:50 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 4a5a54db0f82 | ||||
Projection | none | ETA | none | Target Version | RR17Q2 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | AugustoMauch | |||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0035557: Authentication parameters are also added to url if multi-server is disabled | |||||||
Description | When the multi-server preference is off or there are no multi-servers defined then there is no need to add the authentication parameters to each request as is shown here [1] [1] http://localhost:8080/openbravo/org.openbravo.mobile.core.context?authenticationClient=39363B0921BB4293B48383844325E84C&authenticationToken=y6LzoV4oSNj2JXQcdEHP9g%3D%3D__%3B__NRIFz4jc1dFCV2%2Fj%2FPukdAafaScPkt4BiVVRPJwUwXibli1DbM8QeaYNkKcc1cXAHbk9B1cjMvqVGR5yY5hVSWLzCeCXC0%2Bd4uY874PUKeaVCF4%2BW4vgCL7mmxGnvhPGkFeQpLBpAA06qPlwr35mYM%2F3CYCOXVsgzVsOQIG%2BzZ4Ev0SvW80jt2oEw%2Fzv%2FCDcju9i0CZYKTcWzhwgtj%2FRMmuLNbkOZ5sXpR8cW99PqrKH5Nsyr%2BteKTSxLXTXGsdr&ignoreForConnectionStatus=true [^] | |||||||
Steps To Reproduce | Install retail Define mobile servers Set multi-server preference to N Login to webpos, check the url | |||||||
Proposed Solution | Do not add authentication tokens to the request urls in the client webpos if there are no servers loaded in the client. | |||||||
Tags | Performance | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0095370) shuehner (administrator) 2017-03-17 12:08 |
Adding tag performance as that is every single request and adds overhead to bytes of 'request itself' for all of them. Note: Impact not measured |
(0095396) hgbot (developer) 2017-03-19 10:41 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 4a5a54db0f828010e75ba331a28d522956b84498 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sun Mar 19 10:28:39 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a5a54db0f828010e75ba331a28d522956b84498 [^] Fixes issue 35557: Authentication parameters are also added to url if multi-server is disabled Do not send back authentication params to the client if multi-server is disabled. This prevents the client from using these authentication params. --- M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java --- |
(0095455) AugustoMauch (administrator) 2017-03-21 10:50 |
Code reviewed and verified |
![]() |
|||
Date Modified | Username | Field | Change |
2017-03-17 12:00 | mtaal | New Issue | |
2017-03-17 12:00 | mtaal | Assigned To | => mtaal |
2017-03-17 12:00 | mtaal | OBNetwork customer | => No |
2017-03-17 12:00 | mtaal | Triggers an Emergency Pack | => No |
2017-03-17 12:07 | shuehner | Issue Monitored: shuehner | |
2017-03-17 12:08 | shuehner | Tag Attached: Performance | |
2017-03-17 12:08 | shuehner | Note Added: 0095370 | |
2017-03-19 10:27 | mtaal | Review Assigned To | => AugustoMauch |
2017-03-19 10:41 | hgbot | Checkin | |
2017-03-19 10:41 | hgbot | Note Added: 0095396 | |
2017-03-19 10:41 | hgbot | Status | new => resolved |
2017-03-19 10:41 | hgbot | Resolution | open => fixed |
2017-03-19 10:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a5a54db0f828010e75ba331a28d522956b84498 [^] |
2017-03-21 10:50 | AugustoMauch | Note Added: 0095455 | |
2017-03-21 10:50 | AugustoMauch | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |