Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035557Retail ModulesStoreServerpublic2017-03-17 12:002017-03-21 10:50
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035557: Authentication parameters are also added to url if multi-server is disabled
DescriptionWhen the multi-server preference is off or there are no multi-servers defined then there is no need to add the authentication parameters to each request as is shown here [1]

[1]
http://localhost:8080/openbravo/org.openbravo.mobile.core.context?authenticationClient=39363B0921BB4293B48383844325E84C&authenticationToken=y6LzoV4oSNj2JXQcdEHP9g%3D%3D__%3B__NRIFz4jc1dFCV2%2Fj%2FPukdAafaScPkt4BiVVRPJwUwXibli1DbM8QeaYNkKcc1cXAHbk9B1cjMvqVGR5yY5hVSWLzCeCXC0%2Bd4uY874PUKeaVCF4%2BW4vgCL7mmxGnvhPGkFeQpLBpAA06qPlwr35mYM%2F3CYCOXVsgzVsOQIG%2BzZ4Ev0SvW80jt2oEw%2Fzv%2FCDcju9i0CZYKTcWzhwgtj%2FRMmuLNbkOZ5sXpR8cW99PqrKH5Nsyr%2BteKTSxLXTXGsdr&ignoreForConnectionStatus=true [^]
Steps To ReproduceInstall retail
Define mobile servers
Set multi-server preference to N
Login to webpos, check the url
Proposed SolutionDo not add authentication tokens to the request urls in the client webpos if there are no servers loaded in the client.
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-17 12:00mtaalNew Issue
2017-03-17 12:00mtaalAssigned To => mtaal
2017-03-17 12:00mtaalOBNetwork customer => No
2017-03-17 12:00mtaalTriggers an Emergency Pack => No
2017-03-17 12:07shuehnerIssue Monitored: shuehner
2017-03-17 12:08shuehnerTag Attached: Performance
2017-03-17 12:08shuehnerNote Added: 0095370
2017-03-19 10:27mtaalReview Assigned To => AugustoMauch
2017-03-19 10:41hgbotCheckin
2017-03-19 10:41hgbotNote Added: 0095396
2017-03-19 10:41hgbotStatusnew => resolved
2017-03-19 10:41hgbotResolutionopen => fixed
2017-03-19 10:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a5a54db0f828010e75ba331a28d522956b84498 [^]
2017-03-21 10:50AugustoMauchNote Added: 0095455
2017-03-21 10:50AugustoMauchStatusresolved => closed

Notes
(0095370)
shuehner   
2017-03-17 12:08   
Adding tag performance as that is every single request and adds overhead to bytes of 'request itself' for all of them.
Note: Impact not measured
(0095396)
hgbot   
2017-03-19 10:41   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4a5a54db0f828010e75ba331a28d522956b84498
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:28:39 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a5a54db0f828010e75ba331a28d522956b84498 [^]

Fixes issue 35557: Authentication parameters are also added to url if multi-server is disabled
Do not send back authentication params to the client if multi-server is disabled. This prevents
the client from using these authentication params.

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java
---
(0095455)
AugustoMauch   
2017-03-21 10:50   
Code reviewed and verified