Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035541
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] StoreServermajorhave not tried2017-03-16 13:532017-03-21 11:35
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision44e8f0f349dc
ProjectionnoneETAnoneTarget VersionRR17Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035541: Add a check that the multi-server preference is defined as system and without visibility filters

DescriptionThe multi-server preference should be defined on system level and without visibility filters.

This is specified in the docs [1] but very easy to miss resulting in confusion and loss of time.

[1] http://wiki.openbravo.com/wiki/Store_and_Multi_Server_Preferences [^]
Steps To ReproduceSet the preference to N not in system or add visibility filters, see that multi-server is still enabled
Proposed SolutionAdd a check which logs an exception stack trace or another very clear way that the preference is wrongly set

And add an eventhandler which prevents setting this preference in the wrong way.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 0035804RR17Q3 closedmtaal MobileServerUtils: Incorrectly comparing string values using != instead of equals method 

-  Notes
(0095390)
hgbot (developer)
2017-03-19 10:20

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3e4ca82c28d5b95d4b6ce6d74a8671c18248b9e3
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:20:36 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e4ca82c28d5b95d4b6ce6d74a8671c18248b9e3 [^]

Related to issue 35541: Add a check that the multi-server preference is defined as system and without visibility filters
Call the utility method with client/org filter as the related preference should be defined on system level

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
(0095393)
hgbot (developer)
2017-03-19 10:41

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c89a30497206f6d715ef01eb2e8f408422042a4d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:23:58 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c89a30497206f6d715ef01eb2e8f408422042a4d [^]

Related to issue 35541: Add a check that the multi-server preference is defined as system and without visibility filters
New event handler to check that the multi-server preference is set at the correct level/visibility filters

---
A src/org/openbravo/mobile/core/servercontroller/MultiServerPreferenceEventHandler.java
---
(0095394)
hgbot (developer)
2017-03-19 10:41

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 44e8f0f349dca5f3ad77c01d5ed1b0b571ac9244
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:24:45 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44e8f0f349dca5f3ad77c01d5ed1b0b571ac9244 [^]

Fixes issue 35541: Add a check that the multi-server preference is defined as system and without visibility filters
Add a log statement/check if a multi-server pref is defined wrongly

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java
---
(0095458)
hgbot (developer)
2017-03-21 11:32

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a2ec64cf6992e6ff1a3fb6e6c4e65fa0d767193f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 21 11:29:06 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a2ec64cf6992e6ff1a3fb6e6c4e65fa0d767193f [^]

Related with issue 35541: Creates messages to make them translatable

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/mobile/core/servercontroller/MultiServerPreferenceEventHandler.java
---
(0095459)
AugustoMauch (administrator)
2017-03-21 11:35

 Code reviewed and verified

- Issue History
Date Modified Username Field Change
2017-03-16 13:53 mtaal New Issue
2017-03-16 13:53 mtaal Assigned To => mtaal
2017-03-16 13:53 mtaal OBNetwork customer => No
2017-03-16 13:53 mtaal Triggers an Emergency Pack => No
2017-03-16 13:55 mtaal Proposed Solution updated
2017-03-19 10:20 hgbot Checkin
2017-03-19 10:20 hgbot Note Added: 0095390
2017-03-19 10:41 hgbot Checkin
2017-03-19 10:41 hgbot Note Added: 0095393
2017-03-19 10:41 hgbot Checkin
2017-03-19 10:41 hgbot Note Added: 0095394
2017-03-19 10:41 hgbot Status new => resolved
2017-03-19 10:41 hgbot Resolution open => fixed
2017-03-19 10:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44e8f0f349dca5f3ad77c01d5ed1b0b571ac9244 [^]
2017-03-20 10:48 mtaal Review Assigned To => AugustoMauch
2017-03-21 10:51 AugustoMauch Description Updated View Revisions
2017-03-21 11:32 hgbot Checkin
2017-03-21 11:32 hgbot Note Added: 0095458
2017-03-21 11:35 AugustoMauch Note Added: 0095459
2017-03-21 11:35 AugustoMauch Status resolved => closed
2017-04-20 10:19 mtaal Relationship added causes 0035804

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker