Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035541Retail ModulesStoreServerpublic2017-03-16 13:532017-03-21 11:35
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035541: Add a check that the multi-server preference is defined as system and without visibility filters
DescriptionThe multi-server preference should be defined on system level and without visibility filters.

This is specified in the docs [1] but very easy to miss resulting in confusion and loss of time.

[1] http://wiki.openbravo.com/wiki/Store_and_Multi_Server_Preferences [^]
Steps To ReproduceSet the preference to N not in system or add visibility filters, see that multi-server is still enabled
Proposed SolutionAdd a check which logs an exception stack trace or another very clear way that the preference is wrongly set

And add an eventhandler which prevents setting this preference in the wrong way.
Additional Information
TagsNo tags attached.
Relationships
causes defect 0035804RR17Q3 closed mtaal MobileServerUtils: Incorrectly comparing string values using != instead of equals method 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-16 13:53mtaalNew Issue
2017-03-16 13:53mtaalAssigned To => mtaal
2017-03-16 13:53mtaalOBNetwork customer => No
2017-03-16 13:53mtaalTriggers an Emergency Pack => No
2017-03-16 13:55mtaalProposed Solution updated
2017-03-19 10:20hgbotCheckin
2017-03-19 10:20hgbotNote Added: 0095390
2017-03-19 10:41hgbotCheckin
2017-03-19 10:41hgbotNote Added: 0095393
2017-03-19 10:41hgbotCheckin
2017-03-19 10:41hgbotNote Added: 0095394
2017-03-19 10:41hgbotStatusnew => resolved
2017-03-19 10:41hgbotResolutionopen => fixed
2017-03-19 10:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44e8f0f349dca5f3ad77c01d5ed1b0b571ac9244 [^]
2017-03-20 10:48mtaalReview Assigned To => AugustoMauch
2017-03-21 10:51AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=14852#r14852
2017-03-21 11:32hgbotCheckin
2017-03-21 11:32hgbotNote Added: 0095458
2017-03-21 11:35AugustoMauchNote Added: 0095459
2017-03-21 11:35AugustoMauchStatusresolved => closed
2017-04-20 10:19mtaalRelationship addedcauses 0035804

Notes
(0095390)
hgbot   
2017-03-19 10:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3e4ca82c28d5b95d4b6ce6d74a8671c18248b9e3
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:20:36 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e4ca82c28d5b95d4b6ce6d74a8671c18248b9e3 [^]

Related to issue 35541: Add a check that the multi-server preference is defined as system and without visibility filters
Call the utility method with client/org filter as the related preference should be defined on system level

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
(0095393)
hgbot   
2017-03-19 10:41   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c89a30497206f6d715ef01eb2e8f408422042a4d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:23:58 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c89a30497206f6d715ef01eb2e8f408422042a4d [^]

Related to issue 35541: Add a check that the multi-server preference is defined as system and without visibility filters
New event handler to check that the multi-server preference is set at the correct level/visibility filters

---
A src/org/openbravo/mobile/core/servercontroller/MultiServerPreferenceEventHandler.java
---
(0095394)
hgbot   
2017-03-19 10:41   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 44e8f0f349dca5f3ad77c01d5ed1b0b571ac9244
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 19 10:24:45 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44e8f0f349dca5f3ad77c01d5ed1b0b571ac9244 [^]

Fixes issue 35541: Add a check that the multi-server preference is defined as system and without visibility filters
Add a log statement/check if a multi-server pref is defined wrongly

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java
---
(0095458)
hgbot   
2017-03-21 11:32   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a2ec64cf6992e6ff1a3fb6e6c4e65fa0d767193f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 21 11:29:06 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a2ec64cf6992e6ff1a3fb6e6c4e65fa0d767193f [^]

Related with issue 35541: Creates messages to make them translatable

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/mobile/core/servercontroller/MultiServerPreferenceEventHandler.java
---
(0095459)
AugustoMauch   
2017-03-21 11:35   
Code reviewed and verified