Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0035473 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | have not tried | 2017-03-09 18:06 | 2017-03-16 11:43 | |||
Reporter | adrianromero | View Status | public | |||||
Assigned To | ranjith_qualiantech_com | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR17Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | a5b9ed5a105a | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | marvintm | |||||||
OBNetwork customer | OBPS | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0035473: [SER-QA 2578] Deleted orders must be marked as not delivered | |||||||
Description | If an order is deleted in web pos. It has to be stored in Openbravo as not delivered | |||||||
Steps To Reproduce | * Create an order in Web POS * Add a line * Delete the order * Go to the backend and observer the order has been saved as deleted but it is set as Delivered = yes | |||||||
Proposed Solution | Apply the attached patch | |||||||
Tags | SER-QA | |||||||
Attached Files | ![]() | |||||||
![]() |
|
![]() |
|
(0095016) hgbot (developer) 2017-03-15 09:47 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: a5b9ed5a105ae069a92e4da8383419b476bd7ffe Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Wed Mar 15 11:07:12 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a5b9ed5a105ae069a92e4da8383419b476bd7ffe [^] Fixes issue 0035473: [SER-QA 2578] Deleted orders must be marked as not delivered * If preference "OBPOS_remove_ticket" is enabled, if draft ticket is deleted in POS, isdelivered should be set as "N" --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
(0095017) hgbot (developer) 2017-03-15 09:47 |
Repository: tools/automation/pi-mobile Changeset: 2cf26b4c8e9388db66a54a13648d1db17651b085 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Mar 15 11:07:05 2017 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2cf26b4c8e9388db66a54a13648d1db17651b085 [^] Verifies issue 35473 : Added automated test 'I35473_VerifyOrderDeleiveryWithDeleleTicket' --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35473_VerifyOrderDeleiveryWithDeleleTicket.java --- |
(0095022) AugustoMauch (administrator) 2017-03-15 10:26 |
About this changeset [1], it is not a good practice to have a method called createPreference that depending on a boolean parameter it creates or deletes a preference. It is not intuitive that invoking createPreference(false) would result in deleting a preference. It is better to have one method to create, and another one to delete. [1] https://code.openbravo.com/tools/automation/pi-mobile/rev/2cf26b4c8e9388db66a54a13648d1db17651b085#l1.81 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2017-03-09 18:06 | adrianromero | New Issue | |
2017-03-09 18:06 | adrianromero | Assigned To | => Retail |
2017-03-09 18:06 | adrianromero | OBNetwork customer | => Yes |
2017-03-09 18:06 | adrianromero | Resolution time | => 1490223600 |
2017-03-09 18:06 | adrianromero | Triggers an Emergency Pack | => No |
2017-03-09 18:06 | adrianromero | Tag Attached: SER-QA | |
2017-03-09 18:10 | adrianromero | File Added: Issue35473.patch | |
2017-03-13 11:04 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
2017-03-13 11:04 | ranjith_qualiantech_com | Status | new => scheduled |
2017-03-15 09:47 | hgbot | Checkin | |
2017-03-15 09:47 | hgbot | Note Added: 0095016 | |
2017-03-15 09:47 | hgbot | Status | scheduled => resolved |
2017-03-15 09:47 | hgbot | Resolution | open => fixed |
2017-03-15 09:47 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a5b9ed5a105ae069a92e4da8383419b476bd7ffe [^] |
2017-03-15 09:47 | hgbot | Checkin | |
2017-03-15 09:47 | hgbot | Note Added: 0095017 | |
2017-03-15 10:26 | AugustoMauch | Note Added: 0095022 | |
2017-03-16 11:43 | marvintm | Review Assigned To | => marvintm |
2017-03-16 11:43 | marvintm | Status | resolved => closed |
2017-03-16 11:43 | marvintm | Fixed in Version | => RR17Q2 |
Copyright © 2000 - 2009 MantisBT Group |