Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035473Retail ModulesWeb POSpublic2017-03-09 18:062017-03-16 11:43
Reporteradrianromero 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035473: [SER-QA 2578] Deleted orders must be marked as not delivered
DescriptionIf an order is deleted in web pos. It has to be stored in Openbravo as not delivered
Steps To Reproduce* Create an order in Web POS
* Add a line
* Delete the order
* Go to the backend and observer the order has been saved as deleted but it is set as Delivered = yes
Proposed SolutionApply the attached patch
Additional Information
TagsSER-QA
Relationships
Attached Filespatch Issue35473.patch (1,158) 2017-03-09 18:10
https://issues.openbravo.com/file_download.php?file_id=10548&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-09 18:06adrianromeroNew Issue
2017-03-09 18:06adrianromeroAssigned To => Retail
2017-03-09 18:06adrianromeroOBNetwork customer => Yes
2017-03-09 18:06adrianromeroResolution time => 1490223600
2017-03-09 18:06adrianromeroTriggers an Emergency Pack => No
2017-03-09 18:06adrianromeroTag Attached: SER-QA
2017-03-09 18:10adrianromeroFile Added: Issue35473.patch
2017-03-13 11:04ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-03-13 11:04ranjith_qualiantech_comStatusnew => scheduled
2017-03-15 09:47hgbotCheckin
2017-03-15 09:47hgbotNote Added: 0095016
2017-03-15 09:47hgbotStatusscheduled => resolved
2017-03-15 09:47hgbotResolutionopen => fixed
2017-03-15 09:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a5b9ed5a105ae069a92e4da8383419b476bd7ffe [^]
2017-03-15 09:47hgbotCheckin
2017-03-15 09:47hgbotNote Added: 0095017
2017-03-15 10:26AugustoMauchNote Added: 0095022
2017-03-16 11:43marvintmReview Assigned To => marvintm
2017-03-16 11:43marvintmStatusresolved => closed
2017-03-16 11:43marvintmFixed in Version => RR17Q2

Notes
(0095016)
hgbot   
2017-03-15 09:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a5b9ed5a105ae069a92e4da8383419b476bd7ffe
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Mar 15 11:07:12 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a5b9ed5a105ae069a92e4da8383419b476bd7ffe [^]

Fixes issue 0035473: [SER-QA 2578] Deleted orders must be marked as not delivered

* If preference "OBPOS_remove_ticket" is enabled, if draft ticket is deleted in POS, isdelivered should be set as "N"

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0095017)
hgbot   
2017-03-15 09:47   
Repository: tools/automation/pi-mobile
Changeset: 2cf26b4c8e9388db66a54a13648d1db17651b085
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 15 11:07:05 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2cf26b4c8e9388db66a54a13648d1db17651b085 [^]

Verifies issue 35473 : Added automated test 'I35473_VerifyOrderDeleiveryWithDeleleTicket'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35473_VerifyOrderDeleiveryWithDeleleTicket.java
---
(0095022)
AugustoMauch   
2017-03-15 10:26   
About this changeset [1], it is not a good practice to have a method called createPreference that depending on a boolean parameter it creates or deletes a preference. It is not intuitive that invoking createPreference(false) would result in deleting a preference. It is better to have one method to create, and another one to delete.

[1] https://code.openbravo.com/tools/automation/pi-mobile/rev/2cf26b4c8e9388db66a54a13648d1db17651b085#l1.81 [^]