Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035453
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2017-03-08 16:392017-03-29 11:04
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRR17Q2
StatusclosedFix in branchFixed in SCM revision975c19829eff
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035453: Method FinancialUtils.calculateNetFromGross has been deprecated and is currently used in the "Add Pack" process

DescriptionMethod FinancialUtils.calculateNetFromGross has been deprecated and is currently used in the "Add Pack" process. It should be replaced instead by FinancialUtils.calculateNetAmtFromGross
Steps To ReproduceInstall Retail pack, and check compilation warnings. Realize that there is a deprecation warning in AddPack class.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035428 closedaferraz Openbravo ERP Do not calculate Net Price and Net Amount outside triggers when creating new Order/Invoice with Price Including Taxes 

-  Notes
(0094837)
hgbot (developer)
2017-03-08 16:39

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 975c19829eff98d93e50496652da5e01a6d30605
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Mar 08 16:39:36 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/975c19829eff98d93e50496652da5e01a6d30605 [^]

Fixed issue 35453. Replace deprecated FinancialUtils.calculateNetFromGross method by FinancialUtils.calculateNetAmtFromGross

---
M src/org/openbravo/retail/discounts/AddPack.java
---
(0094839)
hgbot (developer)
2017-03-08 17:05

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 83b052e1b803276cf018fe45aa6ac62c7abdf99d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Mar 08 17:05:01 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/83b052e1b803276cf018fe45aa6ac62c7abdf99d [^]

Related to issue 35453. New method returns net amount. Price should be calculated from it, by dividing it by the quantity.

---
M src/org/openbravo/retail/discounts/AddPack.java
---
(0094854)
hgbot (developer)
2017-03-09 10:05

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 50655c59ea2a2b0f1463c9376c419bfee9db1352
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Mar 09 10:04:42 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/50655c59ea2a2b0f1463c9376c419bfee9db1352 [^]

Related to issue 35453. Use priceprecision to set the price in the line

---
M src/org/openbravo/retail/discounts/AddPack.java
---

- Issue History
Date Modified Username Field Change
2017-03-08 16:39 marvintm New Issue
2017-03-08 16:39 marvintm Assigned To => marvintm
2017-03-08 16:39 marvintm OBNetwork customer => No
2017-03-08 16:39 marvintm Triggers an Emergency Pack => No
2017-03-08 16:39 hgbot Checkin
2017-03-08 16:39 hgbot Note Added: 0094837
2017-03-08 16:39 hgbot Status new => resolved
2017-03-08 16:39 hgbot Resolution open => fixed
2017-03-08 16:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/975c19829eff98d93e50496652da5e01a6d30605 [^]
2017-03-08 16:43 aferraz Relationship added related to 0035428
2017-03-08 17:05 hgbot Checkin
2017-03-08 17:05 hgbot Note Added: 0094839
2017-03-09 10:05 hgbot Checkin
2017-03-09 10:05 hgbot Note Added: 0094854
2017-03-29 11:04 guilleaer Review Assigned To => guilleaer
2017-03-29 11:04 guilleaer Status resolved => closed
2017-03-29 11:04 guilleaer Fixed in Version => RR17Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker