Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035453Retail ModulesWeb POSpublic2017-03-08 16:392017-03-29 11:04
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035453: Method FinancialUtils.calculateNetFromGross has been deprecated and is currently used in the "Add Pack" process
DescriptionMethod FinancialUtils.calculateNetFromGross has been deprecated and is currently used in the "Add Pack" process. It should be replaced instead by FinancialUtils.calculateNetAmtFromGross
Steps To ReproduceInstall Retail pack, and check compilation warnings. Realize that there is a deprecation warning in AddPack class.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035428 closed aferraz Openbravo ERP Do not calculate Net Price and Net Amount outside triggers when creating new Order/Invoice with Price Including Taxes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-03-08 16:39marvintmNew Issue
2017-03-08 16:39marvintmAssigned To => marvintm
2017-03-08 16:39marvintmOBNetwork customer => No
2017-03-08 16:39marvintmTriggers an Emergency Pack => No
2017-03-08 16:39hgbotCheckin
2017-03-08 16:39hgbotNote Added: 0094837
2017-03-08 16:39hgbotStatusnew => resolved
2017-03-08 16:39hgbotResolutionopen => fixed
2017-03-08 16:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/975c19829eff98d93e50496652da5e01a6d30605 [^]
2017-03-08 16:43aferrazRelationship addedrelated to 0035428
2017-03-08 17:05hgbotCheckin
2017-03-08 17:05hgbotNote Added: 0094839
2017-03-09 10:05hgbotCheckin
2017-03-09 10:05hgbotNote Added: 0094854
2017-03-29 11:04guilleaerReview Assigned To => guilleaer
2017-03-29 11:04guilleaerStatusresolved => closed
2017-03-29 11:04guilleaerFixed in Version => RR17Q2

Notes
(0094837)
hgbot   
2017-03-08 16:39   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 975c19829eff98d93e50496652da5e01a6d30605
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Mar 08 16:39:36 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/975c19829eff98d93e50496652da5e01a6d30605 [^]

Fixed issue 35453. Replace deprecated FinancialUtils.calculateNetFromGross method by FinancialUtils.calculateNetAmtFromGross

---
M src/org/openbravo/retail/discounts/AddPack.java
---
(0094839)
hgbot   
2017-03-08 17:05   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 83b052e1b803276cf018fe45aa6ac62c7abdf99d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Mar 08 17:05:01 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/83b052e1b803276cf018fe45aa6ac62c7abdf99d [^]

Related to issue 35453. New method returns net amount. Price should be calculated from it, by dividing it by the quantity.

---
M src/org/openbravo/retail/discounts/AddPack.java
---
(0094854)
hgbot   
2017-03-09 10:05   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 50655c59ea2a2b0f1463c9376c419bfee9db1352
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Mar 09 10:04:42 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/50655c59ea2a2b0f1463c9376c419bfee9db1352 [^]

Related to issue 35453. Use priceprecision to set the price in the line

---
M src/org/openbravo/retail/discounts/AddPack.java
---