0035371: Wrong orders shown in "Create Invoices From Orders" window

Description

Wrong orders shown in "Create Invoices From Orders" window when an order is of type 'POS Order'. Those orders are invoiced by the cashup and must not be returned by this process. Before the update on the view c_invoice_candidate_v those orders were not shown.

Steps To Reproduce

1) Create a new Sales Order:
  - Transaction Document: POS Order
  - Business Partner: Alimentos y Supermercados
  - Invoice Terms: Immediate
1.1) Create a new line for the Sales Order (Cerveza ale 0'5L)
1.2) Book the Sales Order

2) Open it's Inovice (Open the 'cerveza ale' record in form mode and select Linked items/Sales Invoice - Lines and open the invoice)
2.1) Reactivate the invoice and delete a line.
2.3) Then complete the invoice (Complete button)

3) Open the window [Create Invoices From Orders]

--> You can see the POS Order there

Proposed Solution

The part of the c_invoice_candidate_v query
...
AND dt.docbasetype = 'SOO'
       AND ( dt.docsubtypeso <> 'ON'
              OR dt.docsubtypeso <> 'OB'
              OR dt.docsubtypeso <> 'WR' )
...
must be replaced for
...
AND dt.docbasetype = 'SOO'
       AND ( dt.docsubtypeso <> 'ON'
              AND dt.docsubtypeso <> 'OB'
              AND dt.docsubtypeso <> 'WR' )
...
to behave the same as before

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0035341

closed

mcobas

Wrong orders shown in "Create Invoices From Orders" window

Notes
(0094960) hgbot (developer) 2017-03-12 16:57	Repository: erp/backports/3.0PR17Q1 Changeset: df513ce5d089d48e8201ef577c9dfec6840065ab Author: Miguel <martencobasmiguel <at> gmail.com> Date: Thu Mar 09 14:22:29 2017 -0500 URL: http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/df513ce5d089d48e8201ef577c9dfec6840065ab [^] Fixes issue 35371: Wrong orders shown in "Create Invoices From Orders" window Fixed the C_INVOICE_CANDIDATE_V view, changing the condition to not take into account the sales orders different than 'ON' AND 'OB' AND 'WR' instead of using an incorrect OR condition as suggested in the proposed solution. Also were included some performances in the view replacing OR and AND conditions with they respectively translations to IN and NOT IN clauses. --- M src-db/database/model/views/C_INVOICE_CANDIDATE_V.xml ---

(0094962) markmm82 (developer) 2017-03-12 16:59	Code review + Testing OK

Issue History
Date Modified	Username	Field	Change
2017-02-27 19:15	markmm82	Type	defect => backport
2017-02-27 19:15	markmm82	Target Version	=> 3.0PR17Q1
2017-03-12 16:57	hgbot	Checkin
2017-03-12 16:57	hgbot	Note Added: 0094960
2017-03-12 16:57	hgbot	Status	scheduled => resolved
2017-03-12 16:57	hgbot	Resolution	open => fixed
2017-03-12 16:57	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/df513ce5d089d48e8201ef577c9dfec6840065ab [^]
2017-03-12 16:59	markmm82	Review Assigned To	=> markmm82
2017-03-12 16:59	markmm82	Note Added: 0094962
2017-03-12 16:59	markmm82	Status	resolved => closed
2017-03-12 16:59	markmm82	Fixed in Version	=> 3.0PR17Q1